Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Issue 2606023003: Fix flaky NewTabPageTestCase.testOmnibox (Closed)

Created:
3 years, 11 months ago by Olivier
Modified:
3 years, 11 months ago
CC:
chromium-reviews, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flaky NewTabPageTestCase.testOmnibox [google_landing_controller scrolledToTop] is set at the begining of animation. This make taps done just after another tap flaky. Add a wait on animateHeader to wait until animation is finished. BUG=None Committed: https://crrev.com/5c105cf0d1aadeb1bb3ff7eafcb72d84bc432e20 Cr-Commit-Position: refs/heads/master@{#440966}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M ios/chrome/browser/ui/ntp/google_landing_controller.mm View 1 chunk +6 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_egtest.mm View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Olivier
3 years, 11 months ago (2016-12-29 16:42:42 UTC) #2
justincohen
lgtm
3 years, 11 months ago (2016-12-29 17:24:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2606023003/1
3 years, 11 months ago (2016-12-29 17:28:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-29 17:37:24 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:52:34 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c105cf0d1aadeb1bb3ff7eafcb72d84bc432e20
Cr-Commit-Position: refs/heads/master@{#440966}

Powered by Google App Engine
This is Rietveld 408576698