Issue 2606023002: [GeometryInterface] parameter was changed to DOMMatrixReadOnly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2606023002: [GeometryInterface] parameter was changed to DOMMatrixReadOnly. (Closed)

Created:
3 years, 11 months ago by Hwanseung Lee

Modified:
3 years, 8 months ago

Reviewers:

CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[GeometryInterface] parameter was changed to DOMMatrixReadOnly. when performance test, polyfill is faster than native. so in order to know why native is slower than polyfill, parameter of multiply function was changed to DOMMatrixReadOnly instead of DOMMatrixInit. BUG=388780

Patch Set 1 : first commit #

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -0 lines)			Patch
M	third_party/WebKit/Source/core/dom/DOMMatrix.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/dom/DOMMatrix.cpp	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.idl	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Hwanseung Lee

Description was changed from ========== [WIP][GeometryInterface] parameter of multiply function was changed to DOMMatrixReadOnly instead ...

3 years, 11 months ago (2016-12-29 12:23:09 UTC) #1

Patchset #1 (id:1) has been deleted

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages