WebContentsVideoCapture Cleanup: Gut-out dead code, and tighten BUILDs.

WebContentsVideoCapture Cleanup: Gut-out dead code, and tighten BUILDs.

Removes a bunch of dead code that was relevant years ago before Chromium
even had a compositor, including a capture from the "backing store" and
a separate "render thread" for scaling and YUV conversion. Also,
gutted-out and simplified the unit tests.

In addition, BUILD files were modified so that only the platforms that
have implementation build/link the relevant modules.

BUG=159234
Committed: https://crrev.com/32fb89992da01de660b893d746916f587e871dc9
Cr-Commit-Position: refs/heads/master@{#441288}

[miu, 2016-12-28 23:34:48]

The CQ bit was checked by miu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 23:35:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[miu, 2016-12-28 23:37:58]

miu@chromium.org changed reviewers:
+ boliu@chromium.org, mcasas@chromium.org, xjz@chromium.org

[miu, 2016-12-28 23:37:59]

boliu: PTAL at content/browser/BUILD.gn.

mcasas: PTAL at content/browser/renderer_host/media/video_capture_manager.cc.

xjz: PTAL the rest.

[commit-bot: I haz the power, 2016-12-28 23:38:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 23:38:56]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[miu, 2016-12-29 21:52:10]

The CQ bit was checked by miu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-29 21:52:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-29 21:56:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-29 21:56:14]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)

[miu, 2016-12-30 00:04:04]

The CQ bit was checked by miu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-30 00:04:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-30 00:59:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-30 00:59:19]

Dry run: This issue passed the CQ dry run.

[boliu, 2017-01-03 16:41:49]

On 2016/12/28 23:37:59, miu wrote:
> boliu: PTAL at content/browser/BUILD.gn.

lgtm

> 
> mcasas: PTAL at content/browser/renderer_host/media/video_capture_manager.cc.
> 
> xjz: PTAL the rest.

[xjz, 2017-01-03 21:14:11]

lgtm

https://codereview.chromium.org/2605973002/diff/40001/content/browser/media/c...
File content/browser/media/capture/web_contents_video_capture_device_unittest.cc
(right):

https://codereview.chromium.org/2605973002/diff/40001/content/browser/media/c...
content/browser/media/capture/web_contents_video_capture_device_unittest.cc:429:
// Run the current loop until and error is encountered.
nit: s/and/an

[miu, 2017-01-03 21:41:47]

https://codereview.chromium.org/2605973002/diff/40001/content/browser/media/c...
File content/browser/media/capture/web_contents_video_capture_device_unittest.cc
(right):

https://codereview.chromium.org/2605973002/diff/40001/content/browser/media/c...
content/browser/media/capture/web_contents_video_capture_device_unittest.cc:429:
// Run the current loop until and error is encountered.
On 2017/01/03 21:14:11, xjz wrote:
> nit: s/and/an

Done.

[miu, 2017-01-03 21:42:24]

Note: Waiting on https://codereview.chromium.org/2602923002/ to land before
rebasing again before commit of this change.

[mcasas, 2017-01-03 23:20:54]

On 2017/01/03 21:42:24, miu wrote:
> Note: Waiting on https://codereview.chromium.org/2602923002/ to land before
> rebasing again before commit of this change.

video_capture_manager.cc rs lgtm

"Remove - all the dead code!!!"

[miu, 2017-01-03 23:21:46]

The CQ bit was checked by miu@chromium.org

[miu, 2017-01-03 23:21:47]

The patchset sent to the CQ was uploaded after l-g-t-m from xjz@chromium.org,
boliu@chromium.org
Link to the patchset: https://codereview.chromium.org/2605973002/#ps80001
(title: "REBASE")

[commit-bot: I haz the power, 2017-01-03 23:22:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 01:38:57]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1483485706876900,
"parent_rev": "29ea9f78911ec99a18ad65d1e7f03481261114bc", "commit_rev":
"1b4f834c0bab04a2f6a8f5345637b1e96e072738"}

[commit-bot: I haz the power, 2017-01-04 01:39:27]

Description was changed from

==========
WebContentsVideoCapture Cleanup: Gut-out dead code, and tighten BUILDs.

Removes a bunch of dead code that was relevant years ago before Chromium
even had a compositor, including a capture from the "backing store" and
a separate "render thread" for scaling and YUV conversion. Also,
gutted-out and simplified the unit tests.

In addition, BUILD files were modified so that only the platforms that
have implementation build/link the relevant modules.

BUG=159234
==========

to

==========
WebContentsVideoCapture Cleanup: Gut-out dead code, and tighten BUILDs.

Removes a bunch of dead code that was relevant years ago before Chromium
even had a compositor, including a capture from the "backing store" and
a separate "render thread" for scaling and YUV conversion. Also,
gutted-out and simplified the unit tests.

In addition, BUILD files were modified so that only the platforms that
have implementation build/link the relevant modules.

BUG=159234

Review-Url: https://codereview.chromium.org/2605973002
==========

[commit-bot: I haz the power, 2017-01-04 01:39:28]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2017-01-04 01:41:24]

Description was changed from

==========
WebContentsVideoCapture Cleanup: Gut-out dead code, and tighten BUILDs.

Removes a bunch of dead code that was relevant years ago before Chromium
even had a compositor, including a capture from the "backing store" and
a separate "render thread" for scaling and YUV conversion. Also,
gutted-out and simplified the unit tests.

In addition, BUILD files were modified so that only the platforms that
have implementation build/link the relevant modules.

BUG=159234

Review-Url: https://codereview.chromium.org/2605973002
==========

to

==========
WebContentsVideoCapture Cleanup: Gut-out dead code, and tighten BUILDs.

Removes a bunch of dead code that was relevant years ago before Chromium
even had a compositor, including a capture from the "backing store" and
a separate "render thread" for scaling and YUV conversion. Also,
gutted-out and simplified the unit tests.

In addition, BUILD files were modified so that only the platforms that
have implementation build/link the relevant modules.

BUG=159234

Committed: https://crrev.com/32fb89992da01de660b893d746916f587e871dc9
Cr-Commit-Position: refs/heads/master@{#441288}
==========

[commit-bot: I haz the power, 2017-01-04 01:41:26]

Patchset 5 (id:??) landed as
https://crrev.com/32fb89992da01de660b893d746916f587e871dc9
Cr-Commit-Position: refs/heads/master@{#441288}