Stop propagation of dependent configs between toolchains.

Stop propagation of dependent configs between toolchains.

In the following scenario:

//foo:a (toolchain1) -> //foo:b (toolchain2) -> //foo:c (toolchain2)

Any dependent configs from //foo:b or //foo:c will not get added to //foo:a
because it is part of a different toolchain but any dependent config
from //foo:c will still get added to //foo:b because both targets are part of
the same toolchain.

BUG=675224
R=dpranke@chromium.org

Committed: https://crrev.com/d1316080967dfa9cd57b11269e25aedceb170514
Cr-Commit-Position: refs/heads/master@{#441341}

[martijnc, 2016-12-28 23:16:25]

Description was changed from

==========
Stop propagation of configs between toolchains.

BUG=675224
R=dpranke@chromium.org
==========

to

==========
Stop propagation of dependent configs between toolchains.

BUG=675224
R=dpranke@chromium.org
==========

[martijnc, 2016-12-29 17:47:09]

Patchset #2 (id:20001) has been deleted

[martijnc, 2016-12-29 18:13:12]

Description was changed from

==========
Stop propagation of dependent configs between toolchains.

BUG=675224
R=dpranke@chromium.org
==========

to

==========
Stop propagation of dependent configs between toolchains.

In the following scenario:

//foo:a (toolchain1) -> //foo:b (toolchain2) -> //foo:c (toolchain2)

Any dependent configs from //foo:b or //foo:c will not get added to //foo:a
because it is part of a different toolchain but any dependent config
from //foo:c will still get added to //foo:b because both targets are part of
the same toolchain.

BUG=675224
R=dpranke@chromium.org
==========

[martijnc, 2016-12-29 20:29:37]

martijn@martijnc.be changed reviewers:
+ brettw@chromium.org

[martijnc, 2016-12-29 20:29:38]

This CL attempts to fix the cross toolchain propagation of dependent configs
recently discussed on gn-dev [1]. This changes the behavior of
all_dependent_configs and public_configs.

With this CL, targets will ignore dependent configs (all_dependent_configs and
public_configs) from dependencies from a different toolchain.

In the following scenario:

//foo:a (toolchain1) -> //foo:b (toolchain2) -> //foo:c (toolchain1)

any dependent config from //foo:c would be ignored by //foo:b which stops the
cross toolchain propagation of these configs. This also means dependent configs
from //foo:c won't get added to //foo:a either (because //foo:b wouldn't have
it) even though they are in the same toolchain. What is the correct way to
handle those cases?

[1] https://groups.google.com/a/chromium.org/forum/#!topic/gn-dev/QJVti9hdcuA

[brettw, 2017-01-03 20:54:30]

LGTM. Thanks.

[martijnc, 2017-01-04 08:34:45]

The CQ bit was checked by martijn@martijnc.be

[commit-bot: I haz the power, 2017-01-04 08:34:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 08:45:54]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483518885781930,
"parent_rev": "19f60120d0377e2fb094786fa629b03e5e515159", "commit_rev":
"9b7586cf2c478e11e2b0577a5a81f31d75b44b84"}

[commit-bot: I haz the power, 2017-01-04 08:46:23]

Description was changed from

==========
Stop propagation of dependent configs between toolchains.

In the following scenario:

//foo:a (toolchain1) -> //foo:b (toolchain2) -> //foo:c (toolchain2)

Any dependent configs from //foo:b or //foo:c will not get added to //foo:a
because it is part of a different toolchain but any dependent config
from //foo:c will still get added to //foo:b because both targets are part of
the same toolchain.

BUG=675224
R=dpranke@chromium.org
==========

to

==========
Stop propagation of dependent configs between toolchains.

In the following scenario:

//foo:a (toolchain1) -> //foo:b (toolchain2) -> //foo:c (toolchain2)

Any dependent configs from //foo:b or //foo:c will not get added to //foo:a
because it is part of a different toolchain but any dependent config
from //foo:c will still get added to //foo:b because both targets are part of
the same toolchain.

BUG=675224
R=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2605963002
==========

[commit-bot: I haz the power, 2017-01-04 08:46:24]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2017-01-04 08:49:18]

Description was changed from

==========
Stop propagation of dependent configs between toolchains.

In the following scenario:

//foo:a (toolchain1) -> //foo:b (toolchain2) -> //foo:c (toolchain2)

Any dependent configs from //foo:b or //foo:c will not get added to //foo:a
because it is part of a different toolchain but any dependent config
from //foo:c will still get added to //foo:b because both targets are part of
the same toolchain.

BUG=675224
R=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2605963002
==========

to

==========
Stop propagation of dependent configs between toolchains.

In the following scenario:

//foo:a (toolchain1) -> //foo:b (toolchain2) -> //foo:c (toolchain2)

Any dependent configs from //foo:b or //foo:c will not get added to //foo:a
because it is part of a different toolchain but any dependent config
from //foo:c will still get added to //foo:b because both targets are part of
the same toolchain.

BUG=675224
R=dpranke@chromium.org

Committed: https://crrev.com/d1316080967dfa9cd57b11269e25aedceb170514
Cr-Commit-Position: refs/heads/master@{#441341}
==========

[commit-bot: I haz the power, 2017-01-04 08:49:19]

Patchset 3 (id:??) landed as
https://crrev.com/d1316080967dfa9cd57b11269e25aedceb170514
Cr-Commit-Position: refs/heads/master@{#441341}