appengine/findit/handlers/crash/crash_handler.py - Issue 2605943002: Removing the mutation in the factories for getting dep repositories

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/handlers/crash/crash_handler.py

Issue 2605943002: Removing the mutation in the factories for getting dep repositories (Closed)

Patch Set: Added the Factory method to CachedGitilesRepository Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/findit/handlers/crash/crash_handler.py

diff --git a/appengine/findit/handlers/crash/crash_handler.py b/appengine/findit/handlers/crash/crash_handler.py

index b7f7efb5640478cc59842d7cd21164efac9c62fc..31b0f21d24cba94b1e47ff490f00a7307aa85235 100644

--- a/appengine/findit/handlers/crash/crash_handler.py

+++ b/appengine/findit/handlers/crash/crash_handler.py

@@ -129,9 +129,9 @@ def ScheduleNewAnalysis(crash_data):

True if we started a new pipeline; False otherwise.

"""

client_id = crash_data['client_id']

- repository = CachedGitilesRepository(HttpClientAppengine())

# N.B., must call FinditForClientID indirectly, for mock testing.

- findit_client = crash_pipeline.FinditForClientID(client_id, repository)

+ findit_client = crash_pipeline.FinditForClientID(client_id,

+ CachedGitilesRepository.Factory(HttpClientAppengine()))

# Check policy and modify the crash_data as needed.

crash_data = findit_client.CheckPolicy(crash_data)