Removing the mutation in the factories for getting dep repositories

appengine/findit/handlers/crash/crash_handler.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import base64
 import json
 import logging
 
 from common import constants
 from common import appengine_util
@@ skipping 111 matching lines @@
   there's nothing we can do), then we will skip creating the pipeline
   at all.
 
   Args:
     crash_data (JSON): ??
 
   Returns:
     True if we started a new pipeline; False otherwise.
   """
   client_id = crash_data['client_id']
-  repository = CachedGitilesRepository(HttpClientAppengine())
   # N.B., must call FinditForClientID indirectly, for mock testing.
-  findit_client = crash_pipeline.FinditForClientID(client_id, repository)
+  findit_client = crash_pipeline.FinditForClientID(client_id,
+      CachedGitilesRepository.Factory(HttpClientAppengine()))
 
   # Check policy and modify the crash_data as needed.
   crash_data = findit_client.CheckPolicy(crash_data)
   if crash_data is None:
     return False
 
   # Detect the regression range, and decide if we actually need to
   # run a new anlaysis or not.
   if not findit_client._NeedsNewAnalysis(crash_data):
     return False
 
   crash_identifiers = crash_data['crash_identifiers']
   # N.B., we cannot pass ``self`` directly to the _pipeline_cls, because
   # it is not JSON-serializable (and there's no way to make it such,
   # since JSON-serializability is defined by JSON-encoders rather than
   # as methods on the objects being encoded).
   pipeline = crash_pipeline.CrashWrapperPipeline(client_id, crash_identifiers)
   # Attribute defined outside __init__ - pylint: disable=W0201
   pipeline.target = appengine_util.GetTargetNameForModule(
       constants.CRASH_BACKEND[client_id])
   queue_name = constants.CRASH_ANALYSIS_QUEUE[client_id]
   pipeline.start(queue_name=queue_name)
   logging.info('New %s analysis is scheduled for %s', client_id,
                repr(crash_identifiers))
   return True