Removing the mutation in the factories for getting dep repositories

appengine/findit/crash/loglinear/test/changelist_classifier_test.py

Index: appengine/findit/crash/loglinear/test/changelist_classifier_test.py
diff --git a/appengine/findit/crash/loglinear/test/changelist_classifier_test.py b/appengine/findit/crash/loglinear/test/changelist_classifier_test.py
index c80db81d3890d503e9f3e3523e06b9caa705459e..3914e7de094c5b3ca17b283972c26d3af84d0c89 100644
--- a/appengine/findit/crash/loglinear/test/changelist_classifier_test.py
+++ b/appengine/findit/crash/loglinear/test/changelist_classifier_test.py
@@ -117,23 +117,12 @@ class LogLinearChangelistClassifierTest(CrashTestSuite):
         'TopFrameIndex': 1.,
     }
 
-    repository = GitilesRepository(self.GetMockHttpClient())
-
-    # TODO(crbug.com/677224): should replace this with an actual factory.
-    def MutateTheRepo(dep_url): # pragma: no cover
-      """A factory function for returning ``Repository`` objects.
-
-      The current definition captures the functionality of before
-      we factored out this factory method. That is, it's not really a
-      "factory" but rather mutates the main repo object in place. In
-      the future this should be changed to do the right thing instead.
-      """
-      repository.repo_url = dep_url
-      return repository
+    def GitilesRepositoryFactory(repo_url): # pragma: no cover

[Sharu Jiang, 2016/12/30 00:00:46]

nit: MockGitilesRepositoryFactory?

[wrengr, 2017/01/03 19:01:02]

Done.

+      return GitilesRepository(self.GetMockHttpClient(), repo_url)
 
     self.changelist_classifier = (
         loglinear_changelist_classifier.LogLinearChangelistClassifier(
-            repository, MutateTheRepo, weights))
+            GitilesRepositoryFactory, weights))
 
   def testAggregateChangedFilesAggreegates(self):
     """Test that ``AggregateChangedFiles`` does aggregate reasons per file.