Index: appengine/findit/crash/crash_pipeline.py |
diff --git a/appengine/findit/crash/crash_pipeline.py b/appengine/findit/crash/crash_pipeline.py |
index a554223750dbaccbf9785296790a69eae49b4b2e..440d02313ca11087e77a1494fc3eed9e3951e619 100644 |
--- a/appengine/findit/crash/crash_pipeline.py |
+++ b/appengine/findit/crash/crash_pipeline.py |
@@ -17,12 +17,12 @@ from crash import findit_for_chromecrash |
from crash import findit_for_clusterfuzz |
from crash.type_enums import CrashClient |
from libs import time_util |
-from gae_libs.gitiles import cached_gitiles_repository |
+from gae_libs.gitiles.cached_gitiles_repository import CachedGitilesRepository |
from model import analysis_status |
# TODO(http://crbug.com/659346): write complete coverage tests for this. |
-def FinditForClientID(client_id, repository): # pragma: no cover |
+def FinditForClientID(client_id, get_repository): # pragma: no cover |
"""Construct a Findit object from a client id string specifying the class. |
We cannot pass Findit objects to the various methods in |
@@ -52,7 +52,7 @@ def FinditForClientID(client_id, repository): # pragma: no cover |
raise ValueError('FinditForClientID: ' |
'unknown or unsupported client %s' % client_id) |
- return cls(repository) |
+ return cls(get_repository) |
# Some notes about the classes below, for people who are not familiar |
@@ -91,10 +91,8 @@ class CrashBasePipeline(BasePipeline): |
def __init__(self, client_id, crash_identifiers): |
super(CrashBasePipeline, self).__init__(client_id, crash_identifiers) |
self._crash_identifiers = crash_identifiers |
- self._findit = FinditForClientID( |
- client_id, |
- cached_gitiles_repository.CachedGitilesRepository( |
- HttpClientAppengine())) |
+ self._findit = FinditForClientID(client_id, |
+ CachedGitilesRepository.Factory(HttpClientAppengine())) |
Sharu Jiang
2016/12/30 00:00:46
This indentation is incorrect:
https://google.git
wrengr
2017/01/03 19:01:02
Done.
|
@property |
def client_id(self): # pragma: no cover |