Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3026)

Unified Diff: appengine/findit/common/test/chrome_dependency_fetcher_test.py

Issue 2605943002: Removing the mutation in the factories for getting dep repositories (Closed)
Patch Set: Added the Factory method to CachedGitilesRepository Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/common/test/chrome_dependency_fetcher_test.py
diff --git a/appengine/findit/common/test/chrome_dependency_fetcher_test.py b/appengine/findit/common/test/chrome_dependency_fetcher_test.py
index fc47bef1f84db6940d390e62f7587a16cb635885..b74cd9a125ca55d011aa468117458639687e4dcc 100644
--- a/appengine/findit/common/test/chrome_dependency_fetcher_test.py
+++ b/appengine/findit/common/test/chrome_dependency_fetcher_test.py
@@ -35,13 +35,18 @@ class MockGitilesRepository(GitRepository):
return self.RESPONSES.get(path, {}).get(revision, None)
+def MockGitilesRepositoryFactory(repo_url):
+ """A factory for creating ``MockGitilesRepository`` objects."""
+ return MockGitilesRepository(repo_url)
+
+
class ChromiumDEPSTest(testing.AppengineTestCase):
DEPS_GIT = '.DEPS.git'
DEPS = 'DEPS'
deps_downloader = chrome_dependency_fetcher.DEPSDownloader(
- MockGitilesRepository())
+ MockGitilesRepositoryFactory)
chrome_dep_fetcher = chrome_dependency_fetcher.ChromeDependencyFetcher(
- MockGitilesRepository())
+ MockGitilesRepositoryFactory)
def testUseDEPS_GIT(self):
revision = 'abc'
@@ -129,8 +134,8 @@ class ChromiumDEPSTest(testing.AppengineTestCase):
self.mock(http_client_appengine.HttpClientAppengine, '_Get', _MockGet)
deps_downloader = chrome_dependency_fetcher.DEPSDownloader(
- gitiles_repository.GitilesRepository(
- http_client=http_client_appengine.HttpClientAppengine()))
+ lambda repo_url: gitiles_repository.GitilesRepository(
+ http_client_appengine.HttpClientAppengine(), repo_url))
content = deps_downloader.Load(
'http://chrome-internal', '50.0.1234.0', 'DEPS')
self.assertEqual(content, 'Dummy DEPS content')

Powered by Google App Engine
This is Rietveld 408576698