In Git.unstaged_files, handle the case when there are no changes.

In Git.unstaged_files, handle the case when there are no changes.

This is a follow-up fix to a mistake in http://crrev.com/2590693002.

BUG=662584
Committed: https://crrev.com/bae815072a0150bfbeb398de594e505a87877a49
Cr-Commit-Position: refs/heads/master@{#440887}

[qyearsley, 2016-12-28 18:47:19]

qyearsley@chromium.org changed reviewers:
+ wkorman@chromium.org

[qyearsley, 2016-12-28 18:47:20]

https://codereview.chromium.org/2605933002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py
(right):

https://codereview.chromium.org/2605933002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py:127:
unstaged_changes = {}
Here, if there are no changes, then change_lines is [''], and line[1] hits an
IndexError.

[wkorman, 2016-12-28 18:52:38]

lgtm

[qyearsley, 2016-12-28 19:06:17]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2016-12-28 19:06:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 20:24:35]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482951977242770, "parent_rev":
"eeda0a91b96741217756081575f808a068e3cd49", "commit_rev":
"a199d75abd162f557192386c3403f0d026e2dc04"}

[commit-bot: I haz the power, 2016-12-28 20:25:04]

Description was changed from

==========
In Git.unstaged_files, handle the case when there are no changes.

This is a follow-up fix to a mistake in http://crrev.com/2590693002.

BUG=662584
==========

to

==========
In Git.unstaged_files, handle the case when there are no changes.

This is a follow-up fix to a mistake in http://crrev.com/2590693002.

BUG=662584

Review-Url: https://codereview.chromium.org/2605933002
==========

[commit-bot: I haz the power, 2016-12-28 20:25:05]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2017-01-02 15:50:07]

Description was changed from

==========
In Git.unstaged_files, handle the case when there are no changes.

This is a follow-up fix to a mistake in http://crrev.com/2590693002.

BUG=662584

Review-Url: https://codereview.chromium.org/2605933002
==========

to

==========
In Git.unstaged_files, handle the case when there are no changes.

This is a follow-up fix to a mistake in http://crrev.com/2590693002.

BUG=662584

Committed: https://crrev.com/bae815072a0150bfbeb398de594e505a87877a49
Cr-Commit-Position: refs/heads/master@{#440887}
==========

[commit-bot: I haz the power, 2017-01-02 15:50:08]

Patchset 1 (id:??) landed as
https://crrev.com/bae815072a0150bfbeb398de594e505a87877a49
Cr-Commit-Position: refs/heads/master@{#440887}