Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2605923002: Remove base::ScopedPtrHashMap from content/browser/service_worker/. (Closed)

Created:
3 years, 11 months ago by Avi (use Gerrit)
Modified:
3 years, 11 months ago
Reviewers:
michaeln, falken, nhiroki, horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, tzik, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove base::ScopedPtrHashMap from content/browser/service_worker/. BUG=579229 Committed: https://crrev.com/180a8c91cfa09bcdc177722282e13fa64f794334 Cr-Commit-Position: refs/heads/master@{#441320}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -51 lines) Patch
M content/browser/service_worker/service_worker_context_watcher.h View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_context_watcher.cc View 12 chunks +38 lines, -33 lines 0 comments Download
M content/browser/service_worker/service_worker_internals_ui.h View 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_internals_ui.cc View 3 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
Avi (use Gerrit)
To any reviewer in the office.
3 years, 11 months ago (2016-12-28 22:01:01 UTC) #10
michaeln
lgtm
3 years, 11 months ago (2017-01-04 00:59:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2605923002/1
3 years, 11 months ago (2017-01-04 03:38:26 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-04 04:57:00 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 05:00:23 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/180a8c91cfa09bcdc177722282e13fa64f794334
Cr-Commit-Position: refs/heads/master@{#441320}

Powered by Google App Engine
This is Rietveld 408576698