Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2605913002: Fix include import in ios/web (Closed)

Created:
3 years, 11 months ago by Olivier
Modified:
3 years, 11 months ago
CC:
Aaron Boodman, abarth-chromium, cbentzel+watch_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix include import in ios/web List of import -> include +#include "base/logging.h" +#include "base/memory/ref_counted.h" +#include "ios/testing/earl_grey/disabled_test_macros.h" +#include "ios/web/history_state_util.h" +#include "ios/web/navigation/navigation_manager_facade_delegate.h" +#include "ios/web/public/active_state_manager.h" +#include "ios/web/public/interstitials/web_interstitial.h" +#include "ios/web/public/web_state/js/credential_util.h" +#include "ios/web/public/web_state/url_verification_constants.h" +#include "ios/web/public/web_state/web_state_delegate.h" +#include "ios/web/public/web_state/web_state_observer.h" +#include "ios/web/webui/web_ui_ios_controller_factory_registry.h" +#include "ios/web/webui/web_ui_ios_impl.h" +#include "mojo/public/cpp/system/watcher.h" List of include -> import +#import "base/ios/block_types.h" +#import "base/ios/weak_nsobject.h" +#import "base/mac/bind_objc_block.h" +#import "base/mac/objc_property_releaser.h" +#import "base/mac/scoped_nsobject.h" +#import "base/test/ios/wait_util.h" +#import "ios/net/clients/crn_forwarding_network_client.h" +#import "ios/net/cookies/cookie_store_ios.h" +#import "ios/net/request_tracker.h" +#import "ios/testing/wait_util.h" +#import "ios/web/interstitials/native_web_interstitial_impl.h" +#import "ios/web/interstitials/web_interstitial_impl.h" +#import "ios/web/navigation/crw_session_controller.h" +#import "ios/web/navigation/crw_session_entry.h" +#import "ios/web/navigation/navigation_item_impl.h" +#import "ios/web/navigation/navigation_manager_delegate.h" +#import "ios/web/navigation/navigation_manager_impl.h" +#import "ios/web/navigation/nscoder_util.h" +#import "ios/web/net/clients/crw_js_injection_network_client.h" +#import "ios/web/net/clients/crw_redirect_network_client.h" +#import "ios/web/net/clients/crw_redirect_network_client_factory.h" +#import "ios/web/net/cookie_notification_bridge.h" +#import "ios/web/net/crw_cert_verification_controller.h" +#import "ios/web/net/request_group_util.h" +#import "ios/web/net/request_tracker_factory_impl.h" +#import "ios/web/net/request_tracker_impl.h" +#import "ios/web/net/web_http_protocol_handler_delegate.h" +#import "ios/web/public/block_types.h" +#import "ios/web/public/image_fetcher/webp_decoder.h" +#import "ios/web/public/interstitials/web_interstitial_delegate.h" +#import "ios/web/public/navigation_item.h" +#import "ios/web/public/test/response_providers/data_response_provider.h" +#import "ios/web/public/test/response_providers/delayed_response_provider.h" +#import "ios/web/public/test/response_providers/error_page_response_provider.h" +#import "ios/web/public/test/response_providers/file_based_response_provider.h" +#import "ios/web/public/test/response_providers/file_based_response_provider_impl.h" +#import "ios/web/public/test/response_providers/html_response_provider.h" +#import "ios/web/public/test/response_providers/html_response_provider_impl.h" +#import "ios/web/public/test/response_providers/response_provider.h" +#import "ios/web/public/test/response_providers/string_response_provider.h" +#import "ios/web/public/test/test_native_content.h" +#import "ios/web/public/test/test_native_content_provider.h" +#import "ios/web/public/test/test_navigation_manager.h" +#import "ios/web/public/test/test_web_state.h" +#import "ios/web/public/test/test_web_view_content_view.h" +#import "ios/web/public/web_client.h" +#import "ios/web/public/web_state/context_menu_params.h" +#import "ios/web/public/web_state/crw_web_view_proxy.h" +#import "ios/web/public/web_state/ui/crw_content_view.h" +#import "ios/web/public/web_state/ui/crw_web_view_content_view.h" +#import "ios/web/public/web_state/web_state.h" +#import "ios/web/public/web_state/web_state_policy_decider.h" +#import "ios/web/public/web_state/web_state_user_data.h" +#import "ios/web/public/web_view_creation_util.h" +#import "ios/web/shell/shell_web_client.h" +#import "ios/web/web_state/blocked_popup_info.h" +#import "ios/web/web_state/web_state_impl.h" +#import "ios/web/webui/crw_web_ui_page_builder.h" +#import "ios/web/webui/url_fetcher_block_adapter.h" +#import "testing/gtest_mac.h" +#import "ui/base/test/ios/ui_view_test_utils.h" BUG=None Committed: https://crrev.com/4ddcb228b9678207a9128de2966005a1073e5194 Cr-Commit-Position: refs/heads/master@{#440867}

Patch Set 1 #

Total comments: 4

Patch Set 2 : add missing #import #

Unified diffs Side-by-side diffs Delta from patch set Stats (+305 lines, -303 lines) Patch
M ios/web/app/web_main_loop.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/app/web_main_runner.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/browser_state_web_view_partition_inttest.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/web/browser_url_rewriter_impl.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/history_state_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/history_state_util_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/interstitials/html_web_interstitial_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/interstitials/html_web_interstitial_impl.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/web/interstitials/native_web_interstitial_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/web/interstitials/native_web_interstitial_impl.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/web/interstitials/web_interstitial_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/interstitials/web_interstitial_impl.mm View 1 chunk +4 lines, -4 lines 0 comments Download
M ios/web/navigation/crw_session_controller.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/web/navigation/crw_session_controller_unittest.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/web/navigation/crw_session_entry.mm View 1 chunk +4 lines, -4 lines 0 comments Download
M ios/web/navigation/crw_session_entry_unittest.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/web/navigation/navigation_item_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/navigation/navigation_item_impl.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/navigation/navigation_item_impl_unittest.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/web/navigation/navigation_manager_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/navigation/navigation_manager_impl.mm View 2 chunks +6 lines, -6 lines 0 comments Download
M ios/web/navigation/nscoder_util.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/navigation/nscoder_util_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/net/clients/crw_js_injection_network_client.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/net/clients/crw_js_injection_network_client.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/net/clients/crw_js_injection_network_client_factory.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/net/clients/crw_js_injection_network_client_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/net/clients/crw_redirect_network_client.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/net/clients/crw_redirect_network_client_factory.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/net/cookie_notification_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/net/cookie_notification_bridge.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/net/crw_cert_verification_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/net/crw_cert_verification_controller.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/web/net/crw_cert_verification_controller_unittest.mm View 1 chunk +4 lines, -4 lines 0 comments Download
M ios/web/net/crw_ssl_status_updater_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/net/request_group_util.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/net/request_group_util_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/net/request_tracker_factory_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/net/request_tracker_factory_impl.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/web/net/request_tracker_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/net/request_tracker_impl.mm View 2 chunks +4 lines, -4 lines 0 comments Download
M ios/web/net/request_tracker_impl_unittest.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M ios/web/net/web_http_protocol_handler_delegate.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/net/web_http_protocol_handler_delegate_unittest.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/web/public/image_fetcher/image_data_fetcher.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/public/image_fetcher/webp_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/image_fetcher/webp_decoder.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/image_fetcher/webp_decoder_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/public/java_script_dialog_callback.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ios/web/public/origin_util_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/public/test/crw_test_js_injection_receiver.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/test/earl_grey/web_view_actions.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/public/test/earl_grey/web_view_matchers.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/web/public/test/http_server.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/test/http_server_inttest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/public/test/http_server_util.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/public/test/js_test_util.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/test/response_providers/data_response_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/test/response_providers/data_response_provider.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/test/response_providers/delayed_response_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/test/response_providers/delayed_response_provider.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/public/test/response_providers/error_page_response_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/test/response_providers/error_page_response_provider.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/test/response_providers/file_based_response_provider.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/public/test/response_providers/file_based_response_provider.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/test/response_providers/file_based_response_provider_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/test/response_providers/file_based_response_provider_impl.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/public/test/response_providers/html_response_provider.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/web/public/test/response_providers/html_response_provider.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/public/test/response_providers/html_response_provider_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/public/test/response_providers/html_response_provider_impl.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/public/test/response_providers/response_provider.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/test/response_providers/string_response_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/test/response_providers/string_response_provider.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/test/scoped_testing_web_client.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/test/test_native_content.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/public/test/test_native_content_provider.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/test/test_navigation_manager.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/test/test_web_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/public/test/test_web_state.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/test/test_web_view_content_view.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/test/web_js_test.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/test/web_test.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/test/web_test_with_web_state.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/test/web_test_with_web_state.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/public/test/web_view_interaction_test_util.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/test/web_view_interaction_test_util.mm View 1 chunk +4 lines, -4 lines 0 comments Download
M ios/web/public/url_schemes.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/user_agent.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/web_client.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/web_state/context_menu_params.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/web_state/ui/crw_generic_content_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/web_state/ui/crw_web_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/public/web_state/web_state_observer_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/web_state/web_state_user_data.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/shell/app_delegate.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/web/shell/shell_main_delegate.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/shell/shell_url_request_context_getter.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/shell/shell_web_client.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/shell/shell_web_client.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/shell/test/context_menu_egtest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/shell/test/earl_grey/shell_matchers.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/shell/test/meta_tags_egtest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/shell/test/page_state_egtest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/shell/test/pdf_egtest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/shell/test/plugin_placeholder_egtest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/shell/test/redirect_egtest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/shell/view_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/test/web_int_test.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/web_state/blocked_popup_info.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/web_state/blocked_popup_info.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/crw_pass_kit_downloader_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/crw_web_view_proxy_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/web_state/crw_web_view_proxy_impl.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/error_translation_util.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/error_translation_util_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/global_web_state_event_tracker.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/js/common_js_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/js/core_js_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/js/credential_util_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/js/crw_js_injection_manager_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/js/crw_js_plugin_placeholder_manager.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/js/page_script_util.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/js/page_script_util_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/ui/crw_generic_content_view.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 5 chunks +13 lines, -13 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller_container_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/ui/crw_web_controller_container_view.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller_container_view_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/ui/crw_web_controller_observer_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/ui/crw_web_controller_unittest.mm View 3 chunks +8 lines, -8 lines 0 comments Download
M ios/web/web_state/ui/crw_web_view_content_view.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/ui/crw_wk_script_message_router.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/ui/crw_wk_script_message_router_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/ui/web_view_js_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/ui/web_view_js_utils.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/ui/web_view_js_utils_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/ui/wk_back_forward_list_item_holder.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/ui/wk_back_forward_list_item_holder.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/ui/wk_back_forward_list_item_holder_unittest.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/web/web_state/ui/wk_web_view_configuration_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/ui/wk_web_view_configuration_provider_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/web_state/web_state.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/web_state_delegate.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/web_state_delegate_bridge_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/web_state_impl.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M ios/web/web_state/web_state_impl.mm View 2 chunks +10 lines, -10 lines 0 comments Download
M ios/web/web_state/web_state_impl_unittest.mm View 2 chunks +6 lines, -6 lines 0 comments Download
M ios/web/web_state/web_state_observer.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/web_state_policy_decider.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/web_state_weak_ptr_factory.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/web_view_internal_creation_util.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/web_view_internal_creation_util_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/web_state/wk_web_view_security_util_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_view_creation_util.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/webui/crw_web_ui_manager.mm View 2 chunks +5 lines, -5 lines 0 comments Download
M ios/web/webui/crw_web_ui_manager_unittest.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/web/webui/crw_web_ui_page_builder.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/webui/crw_web_ui_page_builder_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/webui/mojo_facade.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/webui/mojo_facade.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/webui/mojo_facade_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/webui/shared_resources_data_source_ios.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/webui/url_data_manager_ios_backend.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/webui/url_data_source_ios.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/webui/url_fetcher_block_adapter.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/webui/url_fetcher_block_adapter_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/webui/web_ui_ios_data_source_impl.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/webui/web_ui_ios_impl.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
Olivier
3 years, 11 months ago (2016-12-28 16:04:19 UTC) #2
Eugene But (OOO till 7-30)
Thank you for doing this! lgtm https://codereview.chromium.org/2605913002/diff/1/ios/web/public/java_script_dialog_presenter.h File ios/web/public/java_script_dialog_presenter.h (right): https://codereview.chromium.org/2605913002/diff/1/ios/web/public/java_script_dialog_presenter.h#newcode8 ios/web/public/java_script_dialog_presenter.h:8: #include "ios/web/public/java_script_dialog_callback.h" As ...
3 years, 11 months ago (2016-12-28 17:27:26 UTC) #7
Olivier
https://codereview.chromium.org/2605913002/diff/1/ios/web/public/java_script_dialog_presenter.h File ios/web/public/java_script_dialog_presenter.h (right): https://codereview.chromium.org/2605913002/diff/1/ios/web/public/java_script_dialog_presenter.h#newcode8 ios/web/public/java_script_dialog_presenter.h:8: #include "ios/web/public/java_script_dialog_callback.h" On 2016/12/28 17:27:26, Eugene But wrote: > ...
3 years, 11 months ago (2016-12-28 17:48:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2605913002/20001
3 years, 11 months ago (2016-12-28 17:48:36 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2016-12-28 18:06:56 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:49:34 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4ddcb228b9678207a9128de2966005a1073e5194
Cr-Commit-Position: refs/heads/master@{#440867}

Powered by Google App Engine
This is Rietveld 408576698