Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 2605853002: Remove an isContextInitialized() check from ScriptController::executeScriptInIsolatedWorld (Closed)

Created:
3 years, 11 months ago by haraken
Modified:
3 years, 11 months ago
Reviewers:
Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove an isContextInitialized() check from ScriptController::executeScriptInIsolatedWorld By checking scriptState->contextIsValid(), we don't need to check isContextInitialized(). BUG=677253 Committed: https://crrev.com/3d044ba6f81e1bd0cd255d4351a811976b80bd50 Cr-Commit-Position: refs/heads/master@{#440841}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
haraken
PTAL
3 years, 11 months ago (2016-12-28 08:52:55 UTC) #2
Yuki
LGTM.
3 years, 11 months ago (2016-12-28 08:55:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2605853002/1
3 years, 11 months ago (2016-12-28 09:02:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-28 10:44:57 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:48:48 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d044ba6f81e1bd0cd255d4351a811976b80bd50
Cr-Commit-Position: refs/heads/master@{#440841}

Powered by Google App Engine
This is Rietveld 408576698