Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3142)

Unified Diff: appengine/findit/waterfall/schedule_try_job_pipeline.py

Issue 2605803002: [Findit] Refactoring WfTryJobData into BaseTryJobData, WfTryJobData, and FlakeTryJobData (Closed)
Patch Set: Fixing code coverage Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/schedule_try_job_pipeline.py
diff --git a/appengine/findit/waterfall/schedule_try_job_pipeline.py b/appengine/findit/waterfall/schedule_try_job_pipeline.py
index bae8b08946415c40ea914b4ac9fd357dfafc9fa3..6517ff1bc2eda7294c8d7d12ded2dc9541fa4d8d 100644
--- a/appengine/findit/waterfall/schedule_try_job_pipeline.py
+++ b/appengine/findit/waterfall/schedule_try_job_pipeline.py
@@ -6,8 +6,6 @@ from common.pipeline_wrapper import BasePipeline
from common.pipeline_wrapper import pipeline
from common.waterfall import buildbucket_client
from common.waterfall import failure_type
-from model.wf_try_job import WfTryJob
-from model.wf_try_job_data import WfTryJobData
from waterfall import buildbot
from waterfall import waterfall_config
@@ -50,18 +48,6 @@ class ScheduleTryJobPipeline(BasePipeline):
return build.id
- def _CreateTryJobData(
- self, build_id, master_name, builder_name, build_number, try_job_type,
- has_compile_targets, has_heuristic_results):
- try_job_data = WfTryJobData.Create(build_id)
- try_job_data.master_name = master_name
- try_job_data.builder_name = builder_name
- try_job_data.build_number = build_number
- try_job_data.try_job_type = try_job_type
- try_job_data.has_compile_targets = has_compile_targets
- try_job_data.has_heuristic_results = has_heuristic_results
- try_job_data.put()
-
# Arguments number differs from overridden method - pylint: disable=W0221
def run(
self, master_name, builder_name, build_number, good_revision,

Powered by Google App Engine
This is Rietveld 408576698