Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2196)

Unified Diff: appengine/findit/waterfall/schedule_test_try_job_pipeline.py

Issue 2605803002: [Findit] Refactoring WfTryJobData into BaseTryJobData, WfTryJobData, and FlakeTryJobData (Closed)
Patch Set: Fixing code coverage Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/schedule_test_try_job_pipeline.py
diff --git a/appengine/findit/waterfall/schedule_test_try_job_pipeline.py b/appengine/findit/waterfall/schedule_test_try_job_pipeline.py
index a6ad02843c919ca636029afe203795d98950527d..2088f9bc78a141e3fe8138e66e1ec95fdde3ff48 100644
--- a/appengine/findit/waterfall/schedule_test_try_job_pipeline.py
+++ b/appengine/findit/waterfall/schedule_test_try_job_pipeline.py
@@ -7,6 +7,7 @@ import logging
from common.waterfall import failure_type
from model.wf_try_job import WfTryJob
+from model.wf_try_job_data import WfTryJobData
from waterfall.schedule_try_job_pipeline import ScheduleTryJobPipeline
@@ -33,6 +34,16 @@ class ScheduleTestTryJobPipeline(ScheduleTryJobPipeline):
return properties
+ def _CreateTryJobData(
+ self, build_id, try_job_key, has_heuristic_results):
+ try_job_data = WfTryJobData.Create(build_id)
+ try_job_data.has_compile_targets = False
+ try_job_data.has_heuristic_results = has_heuristic_results
+ try_job_data.try_job_key = try_job_key
+ try_job_data.try_job_type = failure_type.GetDescriptionForFailureType(
+ failure_type.TEST)
+ try_job_data.put()
+
# Arguments number differs from overridden method - pylint: disable=W0221
def run(
self, master_name, builder_name, build_number, good_revision,
@@ -66,16 +77,13 @@ class ScheduleTestTryJobPipeline(ScheduleTryJobPipeline):
build_id = self._TriggerTryJob(
master_name, builder_name, properties, additional_parameters)
- try_job_result = WfTryJob.Get(master_name, builder_name, build_number)
- try_job_result.test_results.append({'try_job_id': build_id})
- try_job_result.try_job_ids.append(build_id)
- try_job_result.put()
+ try_job = WfTryJob.Get(master_name, builder_name, build_number)
+ try_job.test_results.append({'try_job_id': build_id})
+ try_job.try_job_ids.append(build_id)
+ try_job.put()
# Create a corresponding WfTryJobData entity to capture as much metadata as
# early as possible.
- self._CreateTryJobData(
- build_id, master_name, builder_name, build_number,
- failure_type.GetDescriptionForFailureType(try_job_type),
- False, bool(suspected_revisions))
+ self._CreateTryJobData(build_id, try_job.key, bool(suspected_revisions))
return build_id

Powered by Google App Engine
This is Rietveld 408576698