Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2605793002: [android] Convert linker tests to platform mode. (Closed)

Created:
3 years, 12 months ago by jbudorick
Modified:
3 years, 11 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, jbudorick+watch_chromium.org, jochen+watch_chromium.org, mikecase+watch_chromium.org, mlamouri+watch-content_chromium.org, Peter Beverloo
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[android] Convert linker tests to platform mode. This also includes: - removal of the old base_test_runner + test_dispatcher code, since the linker tests were the last remaining users. - gn changes to make a wrapper script for the linker tests s.t. they can be run with <output directory>/bin/run_chromium_linker_test_apk Committed: https://crrev.com/bf713870ac13487b9a3e2dc639b87f3810058cc9 Cr-Commit-Position: refs/heads/master@{#441274}

Patch Set 1 #

Total comments: 2

Patch Set 2 : mikecase comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -959 lines) Patch
M build/android/PRESUBMIT.py View 2 chunks +1 line, -1 line 0 comments Download
D build/android/pylib/base/base_test_runner.py View 1 chunk +0 lines, -138 lines 0 comments Download
D build/android/pylib/base/test_dispatcher.py View 1 chunk +0 lines, -343 lines 0 comments Download
D build/android/pylib/base/test_dispatcher_unittest.py View 1 chunk +0 lines, -241 lines 0 comments Download
M build/android/pylib/base/test_instance_factory.py View 2 chunks +3 lines, -0 lines 0 comments Download
M build/android/pylib/base/test_run_factory.py View 2 chunks +5 lines, -0 lines 0 comments Download
A build/android/pylib/linker/linker_test_instance.py View 1 1 chunk +56 lines, -0 lines 0 comments Download
D build/android/pylib/linker/setup.py View 1 chunk +0 lines, -60 lines 0 comments Download
M build/android/pylib/linker/test_case.py View 2 chunks +5 lines, -8 lines 0 comments Download
D build/android/pylib/linker/test_runner.py View 1 chunk +0 lines, -97 lines 0 comments Download
A build/android/pylib/local/device/local_device_linker_test_run.py View 1 chunk +76 lines, -0 lines 0 comments Download
M build/android/test_runner.py View 12 chunks +12 lines, -66 lines 0 comments Download
M build/android/test_runner.pydeps View 2 chunks +2 lines, -4 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 1 chunk +5 lines, -0 lines 0 comments Download
M content/shell/android/BUILD.gn View 2 chunks +20 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
jbudorick
3 years, 12 months ago (2016-12-28 00:26:53 UTC) #3
mikecase (-- gone --)
nit: Remove BUG= in commit desc probably if not using it One question about > ...
3 years, 11 months ago (2017-01-03 16:12:49 UTC) #4
jbudorick
+boliu for content/shell/android/ OWNERS https://codereview.chromium.org/2605793002/diff/1/build/android/pylib/linker/linker_test_instance.py File build/android/pylib/linker/linker_test_instance.py (right): https://codereview.chromium.org/2605793002/diff/1/build/android/pylib/linker/linker_test_instance.py#newcode36 build/android/pylib/linker/linker_test_instance.py:36: if min_device_sdk > _MODERN_LINKER_MINIMUM_SDK_INT: On ...
3 years, 11 months ago (2017-01-03 23:37:06 UTC) #7
boliu
lgtm
3 years, 11 months ago (2017-01-03 23:43:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2605793002/20001
3 years, 11 months ago (2017-01-03 23:44:50 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-04 01:17:01 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 01:19:22 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bf713870ac13487b9a3e2dc639b87f3810058cc9
Cr-Commit-Position: refs/heads/master@{#441274}

Powered by Google App Engine
This is Rietveld 408576698