Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js

Issue 2605693003: DevTools: introduce object previews experiment (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js b/third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js
index 2649b9bf678c2c274869f9f751d43e180bea9bb0..11fc49fa3cdbf23707967c8ab70b444f67c74464 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js
@@ -403,18 +403,20 @@ Sources.SourceMapNamesResolver.RemoteObject = class extends SDK.RemoteObject {
/**
* @override
+ * @param {boolean} generatePreview
* @param {function(?Array.<!SDK.RemoteObjectProperty>, ?Array.<!SDK.RemoteObjectProperty>)} callback
*/
- getOwnProperties(callback) {
- this._object.getOwnProperties(callback);
+ getOwnProperties(generatePreview, callback) {
+ this._object.getOwnProperties(generatePreview, callback);
}
/**
* @override
* @param {boolean} accessorPropertiesOnly
+ * @param {boolean} generatePreview
* @param {function(?Array<!SDK.RemoteObjectProperty>, ?Array<!SDK.RemoteObjectProperty>)} callback
*/
- getAllProperties(accessorPropertiesOnly, callback) {
+ getAllProperties(accessorPropertiesOnly, generatePreview, callback) {
/**
* @param {?Array.<!SDK.RemoteObjectProperty>} properties
* @param {?Array.<!SDK.RemoteObjectProperty>} internalProperties
@@ -445,7 +447,7 @@ Sources.SourceMapNamesResolver.RemoteObject = class extends SDK.RemoteObject {
callback(newProperties, internalProperties);
}
- this._object.getAllProperties(accessorPropertiesOnly, wrappedCallback.bind(this));
+ this._object.getAllProperties(accessorPropertiesOnly, generatePreview, wrappedCallback.bind(this));
}
/**

Powered by Google App Engine
This is Rietveld 408576698