third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js - Issue 2605693003: DevTools: introduce object previews experiment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

Issue 2605693003: DevTools: introduce object previews experiment (Closed)

Patch Set: rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js b/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

index 22513acb29a796012e3c8e90d93203916acf4ac4..ba9737d2dbd803b8955b0fcfd85c6508d0a4f8a6 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

@@ -571,7 +571,7 @@ Sources.JavaScriptSourceFrame = class extends SourceFrame.UISourceCodeFrame {

var functionLocation = callFrame.functionLocation();

if (localScope && functionLocation) {

Sources.SourceMapNamesResolver.resolveScopeInObject(localScope)

- .getAllProperties(false, this._prepareScopeVariables.bind(this, callFrame));

+ .getAllProperties(false, false, this._prepareScopeVariables.bind(this, callFrame));

}

if (this._clearValueWidgetsTimer) {

@@ -689,10 +689,12 @@ Sources.JavaScriptSourceFrame = class extends SourceFrame.UISourceCodeFrame {

var value = valuesMap.get(name);

var propertyCount = value.preview ? value.preview.properties.length : 0;

var entryCount = value.preview && value.preview.entries ? value.preview.entries.length : 0;

- if (value.preview && propertyCount + entryCount < 10)

- formatter.appendObjectPreview(nameValuePair, value.preview);

- else

- nameValuePair.appendChild(Components.ObjectPropertiesSection.createValueElement(value, false));

+ if (value.preview && propertyCount + entryCount < 10) {

+ formatter.appendObjectPreview(nameValuePair, value.preview, false /* isEntry */);

+ } else {

+ nameValuePair.appendChild(Components.ObjectPropertiesSection.createValueElement(

+ value, false /* wasThrown */, false /* showPreview */));

+ }

++renderedNameCount;

}