third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js - Issue 2605693003: DevTools: introduce object previews experiment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js

Issue 2605693003: DevTools: introduce object previews experiment (Closed)

Patch Set: fix rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js ('K') | « third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js ('k') | third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js » ('j') | third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js

diff --git a/third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js b/third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js

index f892558204aeca33efd372e05831d51958559cb8..10eb31e2d48e32a5b5571af0666bf87f05a8c1af 100644

--- a/third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js

+++ b/third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js

@@ -138,7 +138,7 @@ Components.ObjectPopoverHelper = class extends UI.PopoverHelper {

if (result.type === 'function') {

result.getOwnProperties(

- didGetFunctionProperties.bind(this, result, popoverContentElement, valueElement, anchorElement));

+ false, didGetFunctionProperties.bind(this, result, popoverContentElement, valueElement, anchorElement));

dgozman 2017/01/13 02:55:41 And here.

luoe 2017/01/13 23:20:12 Done.

return;

}

popover.showForAnchor(popoverContentElement, anchorElement);