third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js - Issue 2605693003: DevTools: introduce object previews experiment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js

Issue 2605693003: DevTools: introduce object previews experiment (Closed)

Patch Set: fix rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/inspector/console/console-format-es6-expected.txt ('K') | « third_party/WebKit/LayoutTests/inspector/runtime/runtime-localStorage-getProperties.html ('k') | third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js » ('j') | third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js

diff --git a/third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js b/third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js

index aa0168a8ec215b41113e844aa554323dec5c780a..a75b8d72e08c7ddd0e162cb0445d992bd643d25f 100644

--- a/third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js

+++ b/third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js

@@ -204,7 +204,7 @@ Components.JavaScriptAutocomplete.completionsForExpression = function(expression

for (var i = 0; i < scopeChain.length; ++i) {

var scope = scopeChain[i];

var object = scope.object();

- object.getAllProperties(false, propertiesCollected.bind(null, scope.typeName()));

+ object.getAllProperties(false, false, propertiesCollected.bind(null, scope.typeName()));

dgozman 2017/01/13 02:55:41 While you are here, could you please annotate it l

luoe 2017/01/13 23:20:12 Done.

}