Remove ActiveDOMCallback

Remove ActiveDOMCallback

ActiveDOMCallback is just checking if the associated ExecutionContext
is suspended or detached. We can do the check using m_scriptState->getExecutionContext().
Then we can remove ActiveDOMCallback.

BUG=610176
Committed: https://crrev.com/6ae3c143f1dfabd596e7db720ff85a0108f1c722
Cr-Commit-Position: refs/heads/master@{#440832}

[haraken, 2016-12-27 12:44:53]

haraken@chromium.org changed reviewers:
+ yukishiino@chromium.org

[haraken, 2016-12-27 12:44:53]

PTAL

[Yuki, 2016-12-27 13:45:10]

Is the CL description really correct?
> if(!canInvokeCallback) is checking if the associated context is detached or
not.

canInvokeCallback() is now checking if the execution context is suspended or not
in addition to if the context is destroyed or not.  Don't we care about
suspension?

[haraken, 2016-12-27 15:06:49]

Description was changed from

==========
Remove ActiveDOMCallback

if(!canInvokeCallback) is checking if the associated context is detached or not.
However, if the context is detached, the following
if(!m_scriptState->contextIsValid)
should return false. (Strictly speaking, that may not be true in some very edge
cases,
but we haven't yet cared about the difference in the code base.)
So the if(!canInvokeCallback) check is redundant.

By removing the check, we can remove ActiveDOMCallback.

BUG=610176
==========

to

==========
Remove ActiveDOMCallback

ActiveDOMCallback is just checking if the associated ExecutionContext
is suspended or detached. We can do the check using
m_scriptState->getExecutionContext().
Then we can remove ActiveDOMCallback.

BUG=610176
==========

[haraken, 2016-12-27 15:07:21]

The CQ bit was checked by haraken@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-27 15:07:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2016-12-27 15:09:18]

On 2016/12/27 13:45:10, Yuki wrote:
> Is the CL description really correct?
> > if(!canInvokeCallback) is checking if the associated context is detached or
> not.
> 
> canInvokeCallback() is now checking if the execution context is suspended or
not
> in addition to if the context is destroyed or not.  Don't we care about
> suspension?

Nice catch. Fixed the issue in PS3.

https://codereview.chromium.org/2605683002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl
(right):

https://codereview.chromium.org/2605683002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl:31: if
(!m_scriptState->contextIsValid())

I guess this check won't be needed because !m_scriptState->contextIsValid() is
equivalent to  executionContext->isContextDestroyed() except some very edge
cases. However, I'll leave the check just in case.

[commit-bot: I haz the power, 2016-12-27 16:40:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-27 16:40:17]

Dry run: This issue passed the CQ dry run.

[Yuki, 2016-12-28 05:19:51]

LGTM.

[haraken, 2016-12-28 05:30:19]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-12-28 05:30:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 05:36:19]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482903019137030,
"parent_rev": "29ef13261ae2959325d04d8e680f3625c35ff4d2", "commit_rev":
"1138c971966f8d3285a4ffcad1732ea7fd8bc0d6"}

[commit-bot: I haz the power, 2016-12-28 05:37:26]

Description was changed from

==========
Remove ActiveDOMCallback

ActiveDOMCallback is just checking if the associated ExecutionContext
is suspended or detached. We can do the check using
m_scriptState->getExecutionContext().
Then we can remove ActiveDOMCallback.

BUG=610176
==========

to

==========
Remove ActiveDOMCallback

ActiveDOMCallback is just checking if the associated ExecutionContext
is suspended or detached. We can do the check using
m_scriptState->getExecutionContext().
Then we can remove ActiveDOMCallback.

BUG=610176

Review-Url: https://codereview.chromium.org/2605683002
==========

[commit-bot: I haz the power, 2016-12-28 05:37:27]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2017-01-02 15:48:32]

Description was changed from

==========
Remove ActiveDOMCallback

ActiveDOMCallback is just checking if the associated ExecutionContext
is suspended or detached. We can do the check using
m_scriptState->getExecutionContext().
Then we can remove ActiveDOMCallback.

BUG=610176

Review-Url: https://codereview.chromium.org/2605683002
==========

to

==========
Remove ActiveDOMCallback

ActiveDOMCallback is just checking if the associated ExecutionContext
is suspended or detached. We can do the check using
m_scriptState->getExecutionContext().
Then we can remove ActiveDOMCallback.

BUG=610176

Committed: https://crrev.com/6ae3c143f1dfabd596e7db720ff85a0108f1c722
Cr-Commit-Position: refs/heads/master@{#440832}
==========

[commit-bot: I haz the power, 2017-01-02 15:48:34]

Patchset 3 (id:??) landed as
https://crrev.com/6ae3c143f1dfabd596e7db720ff85a0108f1c722
Cr-Commit-Position: refs/heads/master@{#440832}