Add gcc_target_rpath gn arg

Add gcc_target_rpath gn arg

Allow a user to make a Chromium build where binaries and shared
libraries are meant to be installed into separate directories, like
/usr/bin/chromium and /usr/lib/chromium for instance. It is useful
when a build system that generates a whole target root filesystem
(like Yocto) is used on top of gn, especially when cross-compiling.

Note: this gn arg is similar to gyp target_rpath generator flag.

BUG=none

Committed: https://crrev.com/5bd06e2b5019b1ab0337083a926a8f672255e065
Cr-Commit-Position: refs/heads/master@{#441344}

[jbriance, 2016-12-27 10:55:46]

jbriance@cisco.com changed reviewers:
+ brettw@chromium.org, dpranke@google.com

[jbriance, 2016-12-27 10:57:36]

Note: gyp generator flag was added in https://codereview.chromium.org/1813053003

[jbriance, 2016-12-27 10:59:08]

Description was changed from

==========
Add gcc_target_rpath gn arg

Allow a user to put shared libraries a in specific directory for
component builds. This gn arg is similar to gyp target_rpath
generator flag.

BUG=none
==========

to

==========
Add gcc_target_rpath gn arg

Allow a user to put shared libraries a in specific directory for
component builds. This gn arg is similar to gyp target_rpath
generator flag.

BUG=none
==========

[jbriance, 2016-12-27 10:59:08]

jbriance@cisco.com changed reviewers:
+ dpranke@chromium.org
- dpranke@google.com

[Dirk Pranke, 2016-12-27 21:08:57]

Can you add something indicating why this is needed, or at least useful?

[jbriance, 2016-12-27 22:27:54]

On 2016/12/27 21:08:57, Dirk Pranke wrote:
> Can you add something indicating why this is needed, or at least useful?

To me, it is useful when using a build system that generates a whole target root
filesystem, like Yocto (especially when you cross-compile).
With this patch, you can easily make a component build and install libraries in
/usr/lib/chromium for instance whereas binaries are in /usr/bin/chromium.
Of course you could also put everything in /usr/bin/chromium, but in this case
you'll have to disable sanity checks, like "do not install shared libraries in a
directory supposed to contain only binaries".

As far as I know, component builds are available for debug purposes, so I will
fully understand if you find this kind of patch not relevant.
On my side, I can easily maintain such a patch downstream. I just wanted to
check if it would be of interest to others :)

[Dirk Pranke, 2016-12-28 00:47:28]

On 2016/12/27 22:27:54, jbriance wrote:
> On 2016/12/27 21:08:57, Dirk Pranke wrote:
> > Can you add something indicating why this is needed, or at least useful?
> 
> To me, it is useful when using a build system that generates a whole target
root
> filesystem, like Yocto (especially when you cross-compile).
> With this patch, you can easily make a component build and install libraries
in
> /usr/lib/chromium for instance whereas binaries are in /usr/bin/chromium.
> Of course you could also put everything in /usr/bin/chromium, but in this case
> you'll have to disable sanity checks, like "do not install shared libraries in
a
> directory supposed to contain only binaries".
> 
> As far as I know, component builds are available for debug purposes, so I will
> fully understand if you find this kind of patch not relevant.
> On my side, I can easily maintain such a patch downstream. I just wanted to
> check if it would be of interest to others :)

I'm sorry, I wasn't clear. The idea behind the patch is fine, I just wanted you
to either add more to the comment in the file, or update the CL description to
describe why this was useful. What you wrote above would be fine.

lgtm otherwise.

[jbriance, 2016-12-28 09:25:20]

Description was changed from

==========
Add gcc_target_rpath gn arg

Allow a user to put shared libraries a in specific directory for
component builds. This gn arg is similar to gyp target_rpath
generator flag.

BUG=none
==========

to

==========
Add gcc_target_rpath gn arg

Allow a user to make a Chromium build where binaries and shared
libraries are meant to be installed into separate directories, like
/usr/bin/chromium and /usr/lib/chromium for instance. It is useful
when a build system that generates a whole target root filesystem
(like Yocto) is used on top of gn, especially when cross-compiling.

Note: this gn arg is similar to gyp target_rpath generator flag.

BUG=none
==========

[jbriance, 2016-12-28 09:25:40]

The CQ bit was checked by jbriance@cisco.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 09:25:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 10:17:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 10:17:21]

Dry run: This issue passed the CQ dry run.

[jbriance, 2016-12-28 10:21:56]

Allright. Could you please take another look dpranke@ ?
If patch set 2 is fine for you I'll send it to CQ.

[jbriance, 2016-12-29 20:26:05]

Ping dpranke@

[Dirk Pranke, 2017-01-04 03:00:58]

lgtm, thanks! And sorry for the delay ...

[jbriance, 2017-01-04 08:05:10]

On 2017/01/04 03:00:58, Dirk Pranke wrote:
> lgtm, thanks! And sorry for the delay ...

No problem at all, I am not in a hurry :)

[jbriance, 2017-01-04 08:05:17]

The CQ bit was checked by jbriance@cisco.com

[commit-bot: I haz the power, 2017-01-04 08:05:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 08:59:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483517117260060,
"parent_rev": "c11821d2e816e13dd0272161a5ae89339306f20b", "commit_rev":
"c506ec4be09b2bf115066921cd66b97a06c641b6"}

[commit-bot: I haz the power, 2017-01-04 08:59:33]

Description was changed from

==========
Add gcc_target_rpath gn arg

Allow a user to make a Chromium build where binaries and shared
libraries are meant to be installed into separate directories, like
/usr/bin/chromium and /usr/lib/chromium for instance. It is useful
when a build system that generates a whole target root filesystem
(like Yocto) is used on top of gn, especially when cross-compiling.

Note: this gn arg is similar to gyp target_rpath generator flag.

BUG=none
==========

to

==========
Add gcc_target_rpath gn arg

Allow a user to make a Chromium build where binaries and shared
libraries are meant to be installed into separate directories, like
/usr/bin/chromium and /usr/lib/chromium for instance. It is useful
when a build system that generates a whole target root filesystem
(like Yocto) is used on top of gn, especially when cross-compiling.

Note: this gn arg is similar to gyp target_rpath generator flag.

BUG=none

Review-Url: https://codereview.chromium.org/2605673002
==========

[commit-bot: I haz the power, 2017-01-04 08:59:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2017-01-04 09:02:21]

Description was changed from

==========
Add gcc_target_rpath gn arg

Allow a user to make a Chromium build where binaries and shared
libraries are meant to be installed into separate directories, like
/usr/bin/chromium and /usr/lib/chromium for instance. It is useful
when a build system that generates a whole target root filesystem
(like Yocto) is used on top of gn, especially when cross-compiling.

Note: this gn arg is similar to gyp target_rpath generator flag.

BUG=none

Review-Url: https://codereview.chromium.org/2605673002
==========

to

==========
Add gcc_target_rpath gn arg

Allow a user to make a Chromium build where binaries and shared
libraries are meant to be installed into separate directories, like
/usr/bin/chromium and /usr/lib/chromium for instance. It is useful
when a build system that generates a whole target root filesystem
(like Yocto) is used on top of gn, especially when cross-compiling.

Note: this gn arg is similar to gyp target_rpath generator flag.

BUG=none

Committed: https://crrev.com/5bd06e2b5019b1ab0337083a926a8f672255e065
Cr-Commit-Position: refs/heads/master@{#441344}
==========

[commit-bot: I haz the power, 2017-01-04 09:02:22]

Patchset 2 (id:??) landed as
https://crrev.com/5bd06e2b5019b1ab0337083a926a8f672255e065
Cr-Commit-Position: refs/heads/master@{#441344}