Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2605603002: Body should use ContextClient instead of ContextLifecycleObserver (Closed)

Created:
3 years, 11 months ago by haraken
Modified:
3 years, 11 months ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Body should use ContextClient instead of ContextLifecycleObserver ContextClient is more lightweight than ContextLifecycleObserver. We prefer ContextClient. BUG=610176 Committed: https://crrev.com/852b53148e04122ccb0c444dff6e8e0cc3939f26 Cr-Commit-Position: refs/heads/master@{#440697}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/modules/fetch/Body.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/Body.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
haraken
PTAL
3 years, 11 months ago (2016-12-26 06:05:23 UTC) #2
sof
lgtm
3 years, 11 months ago (2016-12-26 06:58:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2605603002/1
3 years, 11 months ago (2016-12-26 07:12:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-26 08:30:26 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2016-12-26 08:32:46 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/852b53148e04122ccb0c444dff6e8e0cc3939f26
Cr-Commit-Position: refs/heads/master@{#440697}

Powered by Google App Engine
This is Rietveld 408576698