Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2605563003: Revert of Validate origins when generating subdomain tokens (Closed)

Created:
3 years, 12 months ago by amineer
Modified:
3 years, 12 months ago
CC:
chromium-reviews, iclelland+watch_chromuim.org, chasej+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Validate origins when generating subdomain tokens (patchset #12 id:240001 of https://codereview.chromium.org/2456053004/ ) Reason for revert: Breaks official Android builds, see https://bugs.chromium.org/p/chromium/issues/detail?id=676894 Original issue's description: > Validate origins when generating subdomain tokens > > Subdomain tokens will match against any subdomains of the given origin. > This relaxed matching should not be applied when subdomains represent > separate logical sites (e.g. <user>.github.io). Thus, subdomain tokens > are not to be issued for such domains. For more detail, see the last > question in the Origin Trials developer guide: > https://github.com/jpchase/OriginTrials/blob/gh-pages/developer-guide.md > > This CL adds a utility to validate that a origin is not found in the > Public Suffix List. The token generation script will now call the > utility to check the origin, only for subdomain tokens. The utility > is used when the generation script is manually run by the origin > trials team to issue tokens. The intent is to automate the origin > checks, to reduce the number of manual steps in issuing tokens. > > BUG=658856 > > Committed: https://crrev.com/6205808cb4e9c61264e4aa48676e2f5833a61326 > Cr-Commit-Position: refs/heads/master@{#440554} TBR=iclelland@chromium.org,agrieve@chromium.org,rdsmith@chromium.org,rsleevi@chromium.org,brettw@chromium.org,chasej@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=658856 Committed: https://crrev.com/14e7a72edd0b2d0b313d047e33069cebc76cc0ab Cr-Commit-Position: refs/heads/master@{#440670}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -343 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M build/config/linux/gconf/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/origin_trials/generate_token.py View 6 chunks +0 lines, -39 lines 0 comments Download
D tools/origin_trials/validate_subdomain_origin/BUILD.gn View 1 chunk +0 lines, -20 lines 0 comments Download
D tools/origin_trials/validate_subdomain_origin/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D tools/origin_trials/validate_subdomain_origin/test_validate.py View 1 chunk +0 lines, -100 lines 0 comments Download
D tools/origin_trials/validate_subdomain_origin/validate_subdomain_origin.cc View 1 chunk +0 lines, -173 lines 0 comments Download
M url/features.gni View 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
amineer
Created Revert of Validate origins when generating subdomain tokens
3 years, 12 months ago (2016-12-24 17:35:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2605563003/1
3 years, 12 months ago (2016-12-24 17:36:01 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 12 months ago (2016-12-24 18:42:39 UTC) #6
commit-bot: I haz the power
3 years, 12 months ago (2016-12-24 18:44:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14e7a72edd0b2d0b313d047e33069cebc76cc0ab
Cr-Commit-Position: refs/heads/master@{#440670}

Powered by Google App Engine
This is Rietveld 408576698