blimp/engine/app/blimp_metrics_service_client.cc - Issue 2605553002: Add EffectiveConnectionType enum to the system profile proto

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/engine/app/blimp_metrics_service_client.cc

Issue 2605553002: Add EffectiveConnectionType enum to the system profile proto (Closed)

Patch Set: Update proto, Use interface, pass in ctor Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/engine/app/blimp_metrics_service_client.cc

diff --git a/blimp/engine/app/blimp_metrics_service_client.cc b/blimp/engine/app/blimp_metrics_service_client.cc

index 94bad89691d6c784f077f5211ac2b733d203dab4..31a473fb9da1811394871b834ae17f62fcbceaba 100644

--- a/blimp/engine/app/blimp_metrics_service_client.cc

+++ b/blimp/engine/app/blimp_metrics_service_client.cc

@@ -64,6 +64,8 @@ BlimpMetricsServiceClient::BlimpMetricsServiceClient(

metrics_service_->RegisterMetricsProvider(

base::WrapUnique<metrics::MetricsProvider>(

new metrics::NetworkMetricsProvider(

+ nullptr /* network_quality_task_runner */,

+ nullptr /* network_quality_estimator_provider */,

content::BrowserThread::GetBlockingPool())));

metrics_service_->RegisterMetricsProvider(

base::WrapUnique<metrics::MetricsProvider>(