android_webview/browser/aw_metrics_service_client.cc - Issue 2605553002: Add EffectiveConnectionType enum to the system profile proto

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/aw_metrics_service_client.cc

Issue 2605553002: Add EffectiveConnectionType enum to the system profile proto (Closed)

Patch Set: Update proto, Use interface, pass in ctor Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/browser/aw_metrics_service_client.cc

diff --git a/android_webview/browser/aw_metrics_service_client.cc b/android_webview/browser/aw_metrics_service_client.cc

index 588818d005991d6077e50ab7122598e8efb6c2e0..14c7c622abbfc50646db69d1bff9f3804d51dec1 100644

--- a/android_webview/browser/aw_metrics_service_client.cc

+++ b/android_webview/browser/aw_metrics_service_client.cc

@@ -108,6 +108,8 @@ void AwMetricsServiceClient::InitializeWithGUID(std::string* guid) {

metrics_service_->RegisterMetricsProvider(

std::unique_ptr<metrics::MetricsProvider>(

new metrics::NetworkMetricsProvider(

+ nullptr /* network_quality_task_runner */,

+ nullptr /* network_quality_estimator_provider */,

content::BrowserThread::GetBlockingPool())));

metrics_service_->RegisterMetricsProvider(