Add EffectiveConnectionType enum to the system profile proto

components/metrics/proto/system_profile.proto

Index: components/metrics/proto/system_profile.proto
diff --git a/components/metrics/proto/system_profile.proto b/components/metrics/proto/system_profile.proto
index c116a0a1d1909830675f3e6b3442cae3924b56d0..7020e763aeace6048aa4a7953b4a03d4b0c762c2 100644
--- a/components/metrics/proto/system_profile.proto
+++ b/components/metrics/proto/system_profile.proto
@@ -366,6 +366,22 @@ message SystemProfileProto {
     }
     // Information of the wireless AP that device is connected to.
     optional WifiAccessPoint access_point_info = 5;
+
+    // Derived from net::NetworkQualityEstimator::EffectiveConnectionType
+    // translated through NetworkMetricsProvider::GetConnectionType.
+    enum EffectiveConnectionType {
+      EFFECTIVE_CONNECTION_TYPE_UNKNOWN = 0;
+      EFFECTIVE_CONNECTION_TYPE_OFFLINE = 1;
+      EFFECTIVE_CONNECTION_TYPE_SLOW_2G = 2;
+      EFFECTIVE_CONNECTION_TYPE_2G = 3;
+      EFFECTIVE_CONNECTION_TYPE_3G = 4;
+      EFFECTIVE_CONNECTION_TYPE_4G = 5;
+      // Set to |EFFECTIVE_CONNECTION_TYPE_AMBIGUOUS| true if connection_type
+      // changed during the lifetime of the log.
+      EFFECTIVE_CONNECTION_TYPE_AMBIGUOUS = 6;
+    }
+    // The connection type according to net::NetworkQualityEstimator.

[Alexei Svitkine (slow), 2017/01/03 17:48:48]

Can you expand comment to explain differences with connection_type?

[tbansal1, 2017/01/03 18:55:44]

Done.

+    optional EffectiveConnectionType effective_connection_type = 6;

[Alexei Svitkine (slow), 2017/01/03 17:48:49]

Please send an internal CL with this change to the proto. It will need to land
before this.

[tbansal1, 2017/01/03 18:55:44]

OK, I will do that. But, just to expand on my understanding of protos, are they
not forward/backward compatible?

[asvitkine_google, 2017/01/03 19:04:13]

They are compatible, it's just that for metrics protos, our policy is to land
internal version first to avoid divergence if two people edit a different one
first at the same time and since internal change requires also logs team
approval.

   }
   optional Network network = 13;