Add EffectiveConnectionType enum to the system profile proto

components/metrics/proto/system_profile.proto

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Stores information about the user's brower and system configuration.
 // The system configuration fields are recorded once per client session.
 
 syntax = "proto2";
 
 option optimize_for = LITE_RUNTIME;
@@ skipping 262 matching lines @@
       // flash-based drives.
       optional bool has_seek_penalty = 1;
     }
     // The drive that the application executable was loaded from.
     optional Drive app_drive = 16;
     // The drive that the current user data directory was loaded from.
     optional Drive user_data_drive = 17;
   }
   optional Hardware hardware = 6;
 
   // Information about the network connection.

[Alexei Svitkine (slow), 2017/01/03 17:48:48]

Add a "Next tag:" comment.

[tbansal1, 2017/01/03 18:55:44]

Done.

   message Network {
     // Set to true if connection_type changed during the lifetime of the log.
     optional bool connection_type_is_ambiguous = 1;
 
     // Derived from net::NetworkChangeNotifier::ConnectionType translated
     // through NetworkMetricsProvider::GetConnectionType.
     enum ConnectionType {
       CONNECTION_UNKNOWN = 0;
       CONNECTION_ETHERNET = 1;
       CONNECTION_WIFI = 2;
@@ skipping 65 matching lines @@
         // Identifiers). These are provided by the vendor through WPS
         // (Wireless Provisioning Service) information elements, which
         // identifies the content of the element.
         repeated uint32 element_identifier = 4;
       }
       // The wireless access point vendor information.
       optional VendorInformation vendor_info = 3;
     }
     // Information of the wireless AP that device is connected to.
     optional WifiAccessPoint access_point_info = 5;
+
+    // Derived from net::NetworkQualityEstimator::EffectiveConnectionType
+    // translated through NetworkMetricsProvider::GetConnectionType.
+    enum EffectiveConnectionType {
+      EFFECTIVE_CONNECTION_TYPE_UNKNOWN = 0;
+      EFFECTIVE_CONNECTION_TYPE_OFFLINE = 1;
+      EFFECTIVE_CONNECTION_TYPE_SLOW_2G = 2;
+      EFFECTIVE_CONNECTION_TYPE_2G = 3;
+      EFFECTIVE_CONNECTION_TYPE_3G = 4;
+      EFFECTIVE_CONNECTION_TYPE_4G = 5;
+      // Set to |EFFECTIVE_CONNECTION_TYPE_AMBIGUOUS| true if connection_type
+      // changed during the lifetime of the log.
+      EFFECTIVE_CONNECTION_TYPE_AMBIGUOUS = 6;
+    }
+    // The connection type according to net::NetworkQualityEstimator.

[Alexei Svitkine (slow), 2017/01/03 17:48:48]

Can you expand comment to explain differences with connection_type?

[tbansal1, 2017/01/03 18:55:44]

Done.

+    optional EffectiveConnectionType effective_connection_type = 6;

[Alexei Svitkine (slow), 2017/01/03 17:48:49]

Please send an internal CL with this change to the proto. It will need to land
before this.

[tbansal1, 2017/01/03 18:55:44]

OK, I will do that. But, just to expand on my understanding of protos, are they
not forward/backward compatible?

[asvitkine_google, 2017/01/03 19:04:13]

They are compatible, it's just that for metrics protos, our policy is to land
internal version first to avoid divergence if two people edit a different one
first at the same time and since internal change requires also logs team
approval.

   }
   optional Network network = 13;
 
   // Information on the Google Update install that is managing this client.
   message GoogleUpdate {
     // Whether the Google Update install is system-level or user-level.
     optional bool is_system_install = 1;
 
     // The date at which Google Update last started performing an automatic
     // update check, in seconds since the Unix epoch.
@@ skipping 475 matching lines @@
 
     // The hash of the product version. Might not be set if the product version
     // could not be obtained from the disk.
     optional fixed32 product_version_hash = 4;
 
     // The current state of the product.
     optional AntiVirusState product_state = 5;
   }
   repeated AntiVirusProduct antivirus_product = 23;
 }