Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 2605513002: [ash-md] Changed the system info row height to 40 (instead of 48). (Closed)

Created:
3 years, 12 months ago by bruthig
Modified:
3 years, 11 months ago
Reviewers:
tdanderson, sadrul
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ash-md] Changed the system info row height to 40 (instead of 48). BUG=671816 TEST=TriView.SetMinHeight Committed: https://crrev.com/95b77af28c961cd0c3ef690868464981b156d62e Cr-Commit-Position: refs/heads/master@{#441411}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -13 lines) Patch
M ash/common/system/chromeos/power/power_status_view.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/common/system/chromeos/power/power_status_view.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M ash/common/system/date/date_view.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/common/system/date/system_info_default_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/common/system/tray/tray_constants.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/common/system/tray/tray_constants.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/common/system/tray/tri_view.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/common/system/tray/tri_view.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M ash/common/system/tray/tri_view_unittest.cc View 3 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
bruthig
tdanderson@, can you PTAL?
3 years, 12 months ago (2016-12-23 19:57:36 UTC) #4
bruthig
sadrul@, can you take a look since tdanderson@ is OOO until the 9th?
3 years, 11 months ago (2017-01-03 19:38:20 UTC) #8
sadrul
lgtm
3 years, 11 months ago (2017-01-04 17:22:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2605513002/1
3 years, 11 months ago (2017-01-04 17:37:04 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-04 18:21:11 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 18:24:56 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/95b77af28c961cd0c3ef690868464981b156d62e
Cr-Commit-Position: refs/heads/master@{#441411}

Powered by Google App Engine
This is Rietveld 408576698