Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2605503002: Prerender: Add thread checks to PrerenderResourceThrottle (Closed)

Created:
3 years, 12 months ago by pasko
Modified:
3 years, 11 months ago
Reviewers:
clamy
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prerender: Add thread checks to PrerenderResourceThrottle These are small followup changes for: https://codereview.chromium.org/2602573002/ Adds DCHECK_CURRENTLY_ON() to the methods of the class as requested in the previous codereview. Also fixes a typo. BUG=668714 Review-Url: https://codereview.chromium.org/2605503002 Cr-Commit-Position: refs/heads/master@{#445371} Committed: https://chromium.googlesource.com/chromium/src/+/c2cdce4467fb89b77f62b3b042b5cdfd19739f13

Patch Set 1 #

Total comments: 2

Patch Set 2 : BrowserThread::IO (without content::) everywhere for consistency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M chrome/browser/prerender/prerender_resource_throttle.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_resource_throttle.cc View 1 8 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
pasko
3 years, 12 months ago (2016-12-23 16:40:28 UTC) #5
clamy
Thanks! Lgtm with a nit. https://codereview.chromium.org/2605503002/diff/1/chrome/browser/prerender/prerender_resource_throttle.cc File chrome/browser/prerender/prerender_resource_throttle.cc (right): https://codereview.chromium.org/2605503002/diff/1/chrome/browser/prerender/prerender_resource_throttle.cc#newcode124 chrome/browser/prerender/prerender_resource_throttle.cc:124: DCHECK_CURRENTLY_ON(content::BrowserThread::IO); nit: either use ...
3 years, 11 months ago (2017-01-10 12:22:47 UTC) #8
pasko
thank you for review, Camille https://codereview.chromium.org/2605503002/diff/1/chrome/browser/prerender/prerender_resource_throttle.cc File chrome/browser/prerender/prerender_resource_throttle.cc (right): https://codereview.chromium.org/2605503002/diff/1/chrome/browser/prerender/prerender_resource_throttle.cc#newcode124 chrome/browser/prerender/prerender_resource_throttle.cc:124: DCHECK_CURRENTLY_ON(content::BrowserThread::IO); On 2017/01/10 12:22:46, ...
3 years, 11 months ago (2017-01-23 12:32:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2605503002/20001
3 years, 11 months ago (2017-01-23 12:32:47 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 13:19:20 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c2cdce4467fb89b77f62b3b042b5...

Powered by Google App Engine
This is Rietveld 408576698