Remove usages of raw new

Remove usages of raw new

This change introduces a cleanup mentioned in http://crrev.com/2598003002.
Raw usages of new are replaced by base::MakeUnique.

BUG=676785
R=vabr@chromium.org

Committed: https://crrev.com/3402daf429bf0513a80c06f082d5668b6ec43235
Cr-Commit-Position: refs/heads/master@{#440616}

[jdoerrie, 2016-12-23 09:56:32]

The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-23 09:56:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdoerrie, 2016-12-23 10:01:11]

Hi Vaclav, please take a look :)

https://codereview.chromium.org/2605483002/diff/1/chrome/browser/password_man...
File chrome/browser/password_manager/credential_manager_browsertest.cc (right):

https://codereview.chromium.org/2605483002/diff/1/chrome/browser/password_man...
chrome/browser/password_manager/credential_manager_browsertest.cc:217: auto
prompt_observer(base::MakeUnique<BubbleObserver>(WebContents()));
Thinking of it, all of these usages could be replaced by |BubbleObserver
prompt_observer(WebContents())|, the unique_ptr is not really necessary. Should
I just do that instead?

[vabr (Chromium), 2016-12-23 10:03:46]

This already LGTM, but +1 to the suggestion to allocate BubbleObserver on the
stack instead.

https://codereview.chromium.org/2605483002/diff/1/chrome/browser/password_man...
File chrome/browser/password_manager/credential_manager_browsertest.cc (right):

https://codereview.chromium.org/2605483002/diff/1/chrome/browser/password_man...
chrome/browser/password_manager/credential_manager_browsertest.cc:217: auto
prompt_observer(base::MakeUnique<BubbleObserver>(WebContents()));
On 2016/12/23 10:01:11, jdoerrie wrote:
> Thinking of it, all of these usages could be replaced by |BubbleObserver
> prompt_observer(WebContents())|, the unique_ptr is not really necessary.
Should
> I just do that instead?

That would be great! I think these are smart pointers only because in the past
there were two types of observers (for a bubble and for an infobar, which used
to be on desktop as well). Now it makes sense to just have the BubbleObserver on
the stack.

[jdoerrie, 2016-12-23 10:22:52]

https://codereview.chromium.org/2605483002/diff/1/chrome/browser/password_man...
File chrome/browser/password_manager/credential_manager_browsertest.cc (right):

https://codereview.chromium.org/2605483002/diff/1/chrome/browser/password_man...
chrome/browser/password_manager/credential_manager_browsertest.cc:217: auto
prompt_observer(base::MakeUnique<BubbleObserver>(WebContents()));
On 2016/12/23 10:03:46, vabr (Chromium) wrote:
> On 2016/12/23 10:01:11, jdoerrie wrote:
> > Thinking of it, all of these usages could be replaced by |BubbleObserver
> > prompt_observer(WebContents())|, the unique_ptr is not really necessary.
> Should
> > I just do that instead?
> 
> That would be great! I think these are smart pointers only because in the past
> there were two types of observers (for a bubble and for an infobar, which used
> to be on desktop as well). Now it makes sense to just have the BubbleObserver
on
> the stack.

Done. Thanks for the explanation :)

[jdoerrie, 2016-12-23 10:22:57]

The CQ bit was checked by jdoerrie@chromium.org

[jdoerrie, 2016-12-23 10:22:58]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/2605483002/#ps20001
(title: "Replace unique_ptrs with stack allocations")

[commit-bot: I haz the power, 2016-12-23 10:23:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 11:01:25]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482488577800890,
"parent_rev": "c8814a1ddb5780917d450280e8cdfecf423eb1a5", "commit_rev":
"fc3f8238108cb24f9723ab3c57f111d334d4e135"}

[commit-bot: I haz the power, 2016-12-23 11:02:15]

Description was changed from

==========
Remove usages of raw new

This change introduces a cleanup mentioned in http://crrev.com/2598003002.
Raw usages of new are replaced by base::MakeUnique.

BUG=676785
R=vabr@chromium.org
==========

to

==========
Remove usages of raw new

This change introduces a cleanup mentioned in http://crrev.com/2598003002.
Raw usages of new are replaced by base::MakeUnique.

BUG=676785
R=vabr@chromium.org

Review-Url: https://codereview.chromium.org/2605483002
Committed:
https://chromium.googlesource.com/chromium/src/+/fc3f8238108cb24f9723ab3c57f1...
==========

[commit-bot: I haz the power, 2016-12-23 11:02:15]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fc3f8238108cb24f9723ab3c57f1...

[commit-bot: I haz the power, 2016-12-23 11:04:37]

Description was changed from

==========
Remove usages of raw new

This change introduces a cleanup mentioned in http://crrev.com/2598003002.
Raw usages of new are replaced by base::MakeUnique.

BUG=676785
R=vabr@chromium.org

Review-Url: https://codereview.chromium.org/2605483002
Committed:
https://chromium.googlesource.com/chromium/src/+/fc3f8238108cb24f9723ab3c57f1...
==========

to

==========
Remove usages of raw new

This change introduces a cleanup mentioned in http://crrev.com/2598003002.
Raw usages of new are replaced by base::MakeUnique.

BUG=676785
R=vabr@chromium.org

Committed: https://crrev.com/3402daf429bf0513a80c06f082d5668b6ec43235
Cr-Commit-Position: refs/heads/master@{#440616}
==========

[commit-bot: I haz the power, 2016-12-23 11:04:38]

Patchset 2 (id:??) landed as
https://crrev.com/3402daf429bf0513a80c06f082d5668b6ec43235
Cr-Commit-Position: refs/heads/master@{#440616}