Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2605463002: Remove base::ScopedPtrHashMap from components/nacl/. (Closed)

Created:
3 years, 12 months ago by Avi (use Gerrit)
Modified:
3 years, 11 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove base::ScopedPtrHashMap from components/nacl/. BUG=579229 Committed: https://crrev.com/83e9d4dab16a22a74eecd6b09f2ede14a8db756c Cr-Commit-Position: refs/heads/master@{#440726}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M components/nacl/renderer/ppb_nacl_private_impl.cc View 3 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
Avi (use Gerrit)
Any reviewer in for the holidays, can you take this?
3 years, 12 months ago (2016-12-23 23:09:40 UTC) #10
Mark Seaborn
LGTM
3 years, 12 months ago (2016-12-27 01:24:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2605463002/1
3 years, 12 months ago (2016-12-27 02:37:45 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 12 months ago (2016-12-27 03:26:18 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:45:23 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83e9d4dab16a22a74eecd6b09f2ede14a8db756c
Cr-Commit-Position: refs/heads/master@{#440726}

Powered by Google App Engine
This is Rietveld 408576698