Ensure UI elements contrast with the right frame color.

Ensure UI elements contrast with the right frame color.

With a Windows-drawn titlebar we need to make sure we're reporting the
frame color that Windows uses so that elements like the incognito icon
will contrast correctly. This patch changes theme_service_win to not
assume custom titlebar mode is on when calculating colors.

R=estade@chromium.org
BUG=676566
Committed: https://crrev.com/b052bbc63d486e85df9da4b073c5decd16972a4d
Cr-Commit-Position: refs/heads/master@{#441254}

[Bret, 2016-12-22 23:25:32]

Don't worry about this until January. I'll ping it then.

[Evan Stade, 2016-12-29 16:34:07]

lgtm

https://codereview.chromium.org/2605443002/diff/1/chrome/browser/themes/theme...
File chrome/browser/themes/theme_service_win.cc (right):

https://codereview.chromium.org/2605443002/diff/1/chrome/browser/themes/theme...
chrome/browser/themes/theme_service_win.cc:57: // Fallthrough and use default.
nit: "Fall through"

https://codereview.chromium.org/2605443002/diff/1/chrome/browser/themes/theme...
chrome/browser/themes/theme_service_win.cc:61: if
(inactive_frame_color_from_registry_)
nit: ternary?

https://codereview.chromium.org/2605443002/diff/1/chrome/browser/themes/theme...
chrome/browser/themes/theme_service_win.cc:81: use_dwm_frame_color_ =
can we use base::Optional for dwm_frame_color_ (and perhaps in more places) to
cut down on the number of variables? might make things easier to understand in
GetDefaultColor, which is becoming fairly byzantine.

[Bret, 2017-01-03 22:49:53]

https://codereview.chromium.org/2605443002/diff/1/chrome/browser/themes/theme...
File chrome/browser/themes/theme_service_win.cc (right):

https://codereview.chromium.org/2605443002/diff/1/chrome/browser/themes/theme...
chrome/browser/themes/theme_service_win.cc:57: // Fallthrough and use default.
On 2016/12/29 16:34:07, Evan Stade wrote:
> nit: "Fall through"

Done.

https://codereview.chromium.org/2605443002/diff/1/chrome/browser/themes/theme...
chrome/browser/themes/theme_service_win.cc:61: if
(inactive_frame_color_from_registry_)
On 2016/12/29 16:34:07, Evan Stade wrote:
> nit: ternary?

Done.

https://codereview.chromium.org/2605443002/diff/1/chrome/browser/themes/theme...
chrome/browser/themes/theme_service_win.cc:81: use_dwm_frame_color_ =
On 2016/12/29 16:34:07, Evan Stade wrote:
> can we use base::Optional for dwm_frame_color_ (and perhaps in more places) to
> cut down on the number of variables? might make things easier to understand in
> GetDefaultColor, which is becoming fairly byzantine.

I made this change and it helps a little bit. But the logic itself is kind of
byzantine unfortunately.

[Bret, 2017-01-03 22:49:59]

The CQ bit was checked by bsep@chromium.org

[Bret, 2017-01-03 22:49:59]

The patchset sent to the CQ was uploaded after l-g-t-m from estade@chromium.org
Link to the patchset: https://codereview.chromium.org/2605443002/#ps20001
(title: "use optional")

[commit-bot: I haz the power, 2017-01-03 22:50:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 23:36:54]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483483799534090,
"parent_rev": "fc28977c4bf5bdea3118a32908cba57ec6a6966a", "commit_rev":
"e6828d027b6b282f6f2be3908225dae29c0174d0"}

[commit-bot: I haz the power, 2017-01-03 23:37:22]

Description was changed from

==========
Ensure UI elements contrast with the right frame color.

With a Windows-drawn titlebar we need to make sure we're reporting the
frame color that Windows uses so that elements like the incognito icon
will contrast correctly. This patch changes theme_service_win to not
assume custom titlebar mode is on when calculating colors.

R=estade@chromium.org
BUG=676566
==========

to

==========
Ensure UI elements contrast with the right frame color.

With a Windows-drawn titlebar we need to make sure we're reporting the
frame color that Windows uses so that elements like the incognito icon
will contrast correctly. This patch changes theme_service_win to not
assume custom titlebar mode is on when calculating colors.

R=estade@chromium.org
BUG=676566

Review-Url: https://codereview.chromium.org/2605443002
==========

[commit-bot: I haz the power, 2017-01-03 23:37:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2017-01-03 23:41:20]

Description was changed from

==========
Ensure UI elements contrast with the right frame color.

With a Windows-drawn titlebar we need to make sure we're reporting the
frame color that Windows uses so that elements like the incognito icon
will contrast correctly. This patch changes theme_service_win to not
assume custom titlebar mode is on when calculating colors.

R=estade@chromium.org
BUG=676566

Review-Url: https://codereview.chromium.org/2605443002
==========

to

==========
Ensure UI elements contrast with the right frame color.

With a Windows-drawn titlebar we need to make sure we're reporting the
frame color that Windows uses so that elements like the incognito icon
will contrast correctly. This patch changes theme_service_win to not
assume custom titlebar mode is on when calculating colors.

R=estade@chromium.org
BUG=676566

Committed: https://crrev.com/b052bbc63d486e85df9da4b073c5decd16972a4d
Cr-Commit-Position: refs/heads/master@{#441254}
==========

[commit-bot: I haz the power, 2017-01-03 23:41:21]

Patchset 2 (id:??) landed as
https://crrev.com/b052bbc63d486e85df9da4b073c5decd16972a4d
Cr-Commit-Position: refs/heads/master@{#441254}