Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2605433002: Remove base::ScopedPtrHashMap from chrome/browser/sync_file_system/drive_backend/ (Closed)

Created:
4 years ago by Avi (use Gerrit)
Modified:
3 years, 11 months ago
Reviewers:
kinuko, nhiroki, tzik
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, extensions-reviews_chromium.org, Aaron Boodman, tzik, achuith+watch_chromium.org, abarth-chromium, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, alemate+watch_chromium.org, derat+watch_chromium.org, nhiroki, media-router+watch_chromium.org, mcasas+watch+vc_chromium.org, mlamouri+watch-permissions_chromium.org, oshima+watch_chromium.org, feature-media-reviews_chromium.org, Lei Zhang, tommycli, davemoore+watch_chromium.org, darin (slow to review), kinuko+fileapi, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove base::ScopedPtrHashMap from chrome/browser/sync_file_system/drive_backend/. BUG=579229 Committed: https://crrev.com/c36c1810c42b81e282d7923dd302d58fc4230239 Cr-Commit-Position: refs/heads/master@{#440938}

Patch Set 1 #

Patch Set 2 : rev #

Patch Set 3 : chromeos #

Patch Set 4 : just sync #

Patch Set 5 : no crash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -34 lines) Patch
M chrome/browser/sync_file_system/drive_backend/metadata_database_index.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc View 1 2 3 4 7 chunks +20 lines, -21 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc View 1 2 3 4 3 chunks +14 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_task_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_task_manager.cc View 3 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 31 (26 generated)
Avi (use Gerrit)
For anyone in the office.
3 years, 11 months ago (2016-12-29 00:07:07 UTC) #23
kinuko
lgtm
3 years, 11 months ago (2016-12-29 05:35:58 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2605433002/80001
3 years, 11 months ago (2016-12-29 05:37:05 UTC) #26
commit-bot: I haz the power
Committed patchset #5 (id:80001)
3 years, 11 months ago (2016-12-29 05:41:29 UTC) #29
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:51:46 UTC) #31
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/c36c1810c42b81e282d7923dd302d58fc4230239
Cr-Commit-Position: refs/heads/master@{#440938}

Powered by Google App Engine
This is Rietveld 408576698