Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2605383002: Introduce IncrementLoadEventDelayCount::clearAndCheckLoadEvent() (Closed)

Created:
3 years, 11 months ago by hiroshige
Modified:
3 years, 11 months ago
Reviewers:
Nate Chapin, yhirano
CC:
chromium-reviews, dtapuska+blinkwatch_chromium.org, blink-reviews-events_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce IncrementLoadEventDelayCount::clearAndCheckLoadEvent() This is to enable checkCompleted() to be called synchronously when IncrementLoadEventDelayCount unblocks Document load event (for performance). Particularly, this will be used in https://codereview.chromium.org/2605173002 and https://codereview.chromium.org/2391923002. BUG=624697 Review-Url: https://codereview.chromium.org/2605383002 Cr-Commit-Position: refs/heads/master@{#444552} Committed: https://chromium.googlesource.com/chromium/src/+/857998f6024697334675af683c89e39d804f45a9

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2 lines) Patch
M third_party/WebKit/Source/core/dom/Document.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IncrementLoadEventDelayCount.h View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IncrementLoadEventDelayCount.cpp View 1 chunk +9 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (14 generated)
hiroshige
PTAL.
3 years, 11 months ago (2017-01-06 18:29:07 UTC) #11
yhirano
On 2017/01/06 18:29:07, hiroshige wrote: > PTAL. lgtm if the reviewers are happy with https://codereview.chromium.org/2605173002/.
3 years, 11 months ago (2017-01-11 06:57:00 UTC) #12
hiroshige
japhet@, could you also take a look as a core/ OWNER? Thanks!
3 years, 11 months ago (2017-01-13 18:43:27 UTC) #13
Nate Chapin
This feels a little messy, but I don't have a better idea. LGTM
3 years, 11 months ago (2017-01-18 22:07:01 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2605383002/40001
3 years, 11 months ago (2017-01-18 22:16:20 UTC) #17
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 23:59:21 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/857998f6024697334675af683c89...

Powered by Google App Engine
This is Rietveld 408576698