MD Settings: Internet: Fix Proxy UI

MD Settings: Internet: Fix Proxy UI

This CL:
* Cleans up the network-proxy HTML and JS files
* Adds a 'Save' button for configuring manual proxy configurations
  since a partial configuration might be invalid.
* Prevents updates from overwriting in-progress manual config changes.
* Fixes the mechanism for saving other proxy configurations also.
* Fixes logic determining when fields are editable.

BUG=677357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/6acab6d4d28021d0da0a1f849bb798e5a8930662
Cr-Commit-Position: refs/heads/master@{#441276}

[stevenjb, 2016-12-29 21:24:36]

Description was changed from

==========
MD Settings: Fix Proxy UI

This CL:
* Cleans up the network-proxy HTML and JS files
* Adds a 'Save' button for configuring manual proxy configurations
  since a partial configuration might be invalid.
* Prevents updates from overwriting in-progress manual config changes.
* Fixes the mechanism for saving other proxy configurations also.
* Fixes logic determining when fields are editable.

BUG=677357
==========

to

==========
MD Settings: Fix Proxy UI

This CL:
* Cleans up the network-proxy HTML and JS files
* Adds a 'Save' button for configuring manual proxy configurations
  since a partial configuration might be invalid.
* Prevents updates from overwriting in-progress manual config changes.
* Fixes the mechanism for saving other proxy configurations also.
* Fixes logic determining when fields are editable.

BUG=677357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2016-12-29 21:25:37]

Description was changed from

==========
MD Settings: Fix Proxy UI

This CL:
* Cleans up the network-proxy HTML and JS files
* Adds a 'Save' button for configuring manual proxy configurations
  since a partial configuration might be invalid.
* Prevents updates from overwriting in-progress manual config changes.
* Fixes the mechanism for saving other proxy configurations also.
* Fixes logic determining when fields are editable.

BUG=677357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Internet: Fix Proxy UI

This CL:
* Cleans up the network-proxy HTML and JS files
* Adds a 'Save' button for configuring manual proxy configurations
  since a partial configuration might be invalid.
* Prevents updates from overwriting in-progress manual config changes.
* Fixes the mechanism for saving other proxy configurations also.
* Fixes logic determining when fields are editable.

BUG=677357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2016-12-29 21:35:01]

stevenjb@chromium.org changed reviewers:
+ michaelpg@chromium.org

[michaelpg, 2017-01-03 20:42:37]

I can't follow all of the proxyModified_ dirty-bit stuff without the UI in front
of me, but it looks okay at a high level. LGTM assuming you tested edge cases.

https://codereview.chromium.org/2605373002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/network_proxy.js (right):

https://codereview.chromium.org/2605373002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/network_proxy.js:38: * @type
{!CrOnc.ProxySettings}
@private

https://codereview.chromium.org/2605373002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/network_proxy.js:47: /** The Web
Proxy Auto Discovery URL extracted from networkProperties. */
@private

https://codereview.chromium.org/2605373002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/network_proxy.js:167:
CrOnc.getSimpleActiveProperties(proxySettings.Manual.HTTPProxy)) ||
indent as below, maybe?

https://codereview.chromium.org/2605373002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/network_proxy.js:401: return
true;  // No proxy settings defined, so not enfirced.
enforced

[stevenjb, 2017-01-03 23:56:55]

https://codereview.chromium.org/2605373002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/network_proxy.js (right):

https://codereview.chromium.org/2605373002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/network_proxy.js:38: * @type
{!CrOnc.ProxySettings}
On 2017/01/03 20:42:37, michaelpg (NYC) wrote:
> @private

Done.

https://codereview.chromium.org/2605373002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/network_proxy.js:47: /** The Web
Proxy Auto Discovery URL extracted from networkProperties. */
On 2017/01/03 20:42:37, michaelpg (NYC) wrote:
> @private

Done.

https://codereview.chromium.org/2605373002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/network_proxy.js:167:
CrOnc.getSimpleActiveProperties(proxySettings.Manual.HTTPProxy)) ||
On 2017/01/03 20:42:37, michaelpg (NYC) wrote:
> indent as below, maybe?

Done.

https://codereview.chromium.org/2605373002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/network_proxy.js:401: return
true;  // No proxy settings defined, so not enfirced.
On 2017/01/03 20:42:37, michaelpg (NYC) wrote:
> enforced

Done.

[stevenjb, 2017-01-03 23:57:30]

On 2017/01/03 20:42:37, michaelpg (NYC) wrote:
> I can't follow all of the proxyModified_ dirty-bit stuff without the UI in
front
> of me, but it looks okay at a high level. LGTM assuming you tested edge cases.
> 
>
https://codereview.chromium.org/2605373002/diff/20001/chrome/browser/resource...
> File chrome/browser/resources/settings/internet_page/network_proxy.js (right):
> 
>
https://codereview.chromium.org/2605373002/diff/20001/chrome/browser/resource...
> chrome/browser/resources/settings/internet_page/network_proxy.js:38: * @type
> {!CrOnc.ProxySettings}
> @private
> 
>
https://codereview.chromium.org/2605373002/diff/20001/chrome/browser/resource...
> chrome/browser/resources/settings/internet_page/network_proxy.js:47: /** The
Web
> Proxy Auto Discovery URL extracted from networkProperties. */
> @private
> 
>
https://codereview.chromium.org/2605373002/diff/20001/chrome/browser/resource...
> chrome/browser/resources/settings/internet_page/network_proxy.js:167:
> CrOnc.getSimpleActiveProperties(proxySettings.Manual.HTTPProxy)) ||
> indent as below, maybe?
> 
>
https://codereview.chromium.org/2605373002/diff/20001/chrome/browser/resource...
> chrome/browser/resources/settings/internet_page/network_proxy.js:401: return
> true;  // No proxy settings defined, so not enfirced.
> enforced

Yeah, I did a fair bit of testing on this, but it's tricky at best. Thanks for
reviewing.

[stevenjb, 2017-01-03 23:57:37]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2017-01-03 23:57:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2605373002/#ps40001
(title: "Rebase, Fix comments / formatting")

[commit-bot: I haz the power, 2017-01-03 23:58:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 01:19:02]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483487857585520,
"parent_rev": "dcbd3d9041935a274a9e57361b984f5fae4ef6d7", "commit_rev":
"6d51fc91e999a28297af846de0c9084a980dd3da"}

[commit-bot: I haz the power, 2017-01-04 01:19:58]

Description was changed from

==========
MD Settings: Internet: Fix Proxy UI

This CL:
* Cleans up the network-proxy HTML and JS files
* Adds a 'Save' button for configuring manual proxy configurations
  since a partial configuration might be invalid.
* Prevents updates from overwriting in-progress manual config changes.
* Fixes the mechanism for saving other proxy configurations also.
* Fixes logic determining when fields are editable.

BUG=677357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Internet: Fix Proxy UI

This CL:
* Cleans up the network-proxy HTML and JS files
* Adds a 'Save' button for configuring manual proxy configurations
  since a partial configuration might be invalid.
* Prevents updates from overwriting in-progress manual config changes.
* Fixes the mechanism for saving other proxy configurations also.
* Fixes logic determining when fields are editable.

BUG=677357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2605373002
==========

[commit-bot: I haz the power, 2017-01-04 01:19:59]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2017-01-04 01:23:29]

Description was changed from

==========
MD Settings: Internet: Fix Proxy UI

This CL:
* Cleans up the network-proxy HTML and JS files
* Adds a 'Save' button for configuring manual proxy configurations
  since a partial configuration might be invalid.
* Prevents updates from overwriting in-progress manual config changes.
* Fixes the mechanism for saving other proxy configurations also.
* Fixes logic determining when fields are editable.

BUG=677357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2605373002
==========

to

==========
MD Settings: Internet: Fix Proxy UI

This CL:
* Cleans up the network-proxy HTML and JS files
* Adds a 'Save' button for configuring manual proxy configurations
  since a partial configuration might be invalid.
* Prevents updates from overwriting in-progress manual config changes.
* Fixes the mechanism for saving other proxy configurations also.
* Fixes logic determining when fields are editable.

BUG=677357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/6acab6d4d28021d0da0a1f849bb798e5a8930662
Cr-Commit-Position: refs/heads/master@{#441276}
==========

[commit-bot: I haz the power, 2017-01-04 01:23:30]

Patchset 3 (id:??) landed as
https://crrev.com/6acab6d4d28021d0da0a1f849bb798e5a8930662
Cr-Commit-Position: refs/heads/master@{#441276}