[Extensions Bindings] Allow event listener unregistration in handling

[Extensions Bindings] Allow event listener unregistration in handling

Event listeners can potentially unregister themselves in the handling of
the event, e.g.
chrome.foo.onBar.addListener(function listener() {
  chrome.foo.onBar.removeListener(listener);
  <do stuff>
});

Support this behavior and add a test.

BUG=653596
Review-Url: https://codereview.chromium.org/2605353003
Cr-Commit-Position: refs/heads/master@{#441729}
Committed: https://chromium.googlesource.com/chromium/src/+/930c8e9b9bf2c2c2bd4ed42ab4939562fa6402d4

[Devlin, 2016-12-29 23:10:11]

rdevlin.cronin@chromium.org changed reviewers:
+ jbroman@chromium.org, lazyboy@chromium.org

[Devlin, 2016-12-29 23:10:11]

And one last one for now.

[jbroman, 2017-01-02 20:30:32]

ok lgtm

https://codereview.chromium.org/2605353003/diff/20001/extensions/renderer/api...
File extensions/renderer/api_event_handler_unittest.cc (right):

https://codereview.chromium.org/2605353003/diff/20001/extensions/renderer/api...
extensions/renderer/api_event_handler_unittest.cc:475: "(function listener%d()
{\n"
nit: You could also do this to avoid the neat to printf, just using an anonymous
function to separate out the variable names. Since this is a test, I don't feel
strongly.

(function() {
  return function listener() {
    this.testEvent.removeListener(listener);
  }
})();

[Devlin, 2017-01-04 18:14:54]

https://codereview.chromium.org/2605353003/diff/20001/extensions/renderer/api...
File extensions/renderer/api_event_handler_unittest.cc (right):

https://codereview.chromium.org/2605353003/diff/20001/extensions/renderer/api...
extensions/renderer/api_event_handler_unittest.cc:475: "(function listener%d()
{\n"
On 2017/01/02 20:30:32, jbroman wrote:
> nit: You could also do this to avoid the neat to printf, just using an
anonymous
> function to separate out the variable names. Since this is a test, I don't
feel
> strongly.
> 
> (function() {
>   return function listener() {
>     this.testEvent.removeListener(listener);
>   }
> })();

I like it, done.

[lazyboy, 2017-01-04 22:15:35]

lgtm

[Devlin, 2017-01-05 17:18:13]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 17:18:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 18:12:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 18:12:07]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-01-05 19:20:01]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2017-01-05 19:20:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbroman@chromium.org, lazyboy@chromium.org
Link to the patchset: https://codereview.chromium.org/2605353003/#ps60001
(title: ".")

[commit-bot: I haz the power, 2017-01-05 19:20:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 19:31:26]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483644001072390,
"parent_rev": "ef539afd778d1f0646d372b45082700bd4537cac", "commit_rev":
"930c8e9b9bf2c2c2bd4ed42ab4939562fa6402d4"}

[commit-bot: I haz the power, 2017-01-05 19:31:52]

Description was changed from

==========
[Extensions Bindings] Allow event listener unregistration in handling

Event listeners can potentially unregister themselves in the handling of
the event, e.g.
chrome.foo.onBar.addListener(function listener() {
  chrome.foo.onBar.removeListener(listener);
  <do stuff>
});

Support this behavior and add a test.

BUG=653596
==========

to

==========
[Extensions Bindings] Allow event listener unregistration in handling

Event listeners can potentially unregister themselves in the handling of
the event, e.g.
chrome.foo.onBar.addListener(function listener() {
  chrome.foo.onBar.removeListener(listener);
  <do stuff>
});

Support this behavior and add a test.

BUG=653596

Review-Url: https://codereview.chromium.org/2605353003
Cr-Commit-Position: refs/heads/master@{#441729}
Committed:
https://chromium.googlesource.com/chromium/src/+/930c8e9b9bf2c2c2bd4ed42ab493...
==========

[commit-bot: I haz the power, 2017-01-05 19:31:52]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/930c8e9b9bf2c2c2bd4ed42ab493...