Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: net/http/http_response_headers_unittest.cc

Issue 2605293002: Add WARN_UNUSED_RESULT to base::Time methods that return bool. (Closed)
Patch Set: Fix ChromeOS unit-test Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_response_headers_unittest.cc
diff --git a/net/http/http_response_headers_unittest.cc b/net/http/http_response_headers_unittest.cc
index 2f2f7befb05e9b7eed94adcc7a71a8760e14fc1b..4ad81c5e11cf0ab5bb2da8c8c4cf95b27a73b1e6 100644
--- a/net/http/http_response_headers_unittest.cc
+++ b/net/http/http_response_headers_unittest.cc
@@ -11,6 +11,7 @@
#include <limits>
#include <memory>
+#include "base/macros.h"
#include "base/pickle.h"
#include "base/time/time.h"
#include "base/values.h"
@@ -780,9 +781,12 @@ TEST_P(RequiresValidationTest, RequiresValidation) {
const RequiresValidationTestData test = GetParam();
base::Time request_time, response_time, current_time;
- base::Time::FromString("Wed, 28 Nov 2007 00:40:09 GMT", &request_time);
- base::Time::FromString("Wed, 28 Nov 2007 00:40:12 GMT", &response_time);
- base::Time::FromString("Wed, 28 Nov 2007 00:45:20 GMT", &current_time);
+ ignore_result(
+ base::Time::FromString("Wed, 28 Nov 2007 00:40:09 GMT", &request_time));
+ ignore_result(
+ base::Time::FromString("Wed, 28 Nov 2007 00:40:12 GMT", &response_time));
+ ignore_result(
+ base::Time::FromString("Wed, 28 Nov 2007 00:45:20 GMT", &current_time));
mmenke 2017/01/03 15:39:24 Should these all be ASSERT_TRUE?
digit1 2017/01/03 16:44:53 Yes, that sounds more logical, I've uploaded a new
std::string headers(test.headers);
HeadersToRaw(&headers);

Powered by Google App Engine
This is Rietveld 408576698