Add WARN_UNUSED_RESULT to base::Time methods that return bool.

net/http/http_response_headers_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_response_headers.h"
 
 #include <stdint.h>
 
 #include <algorithm>
 #include <iostream>
 #include <limits>
 #include <memory>
 
+#include "base/macros.h"
 #include "base/pickle.h"
 #include "base/time/time.h"
 #include "base/values.h"
 #include "net/http/http_byte_range.h"
 #include "net/log/net_log_capture_mode.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace net {
 
 namespace {
@@ skipping 749 matching lines @@
 
 class RequiresValidationTest
     : public HttpResponseHeadersTest,
       public ::testing::WithParamInterface<RequiresValidationTestData> {
 };
 
 TEST_P(RequiresValidationTest, RequiresValidation) {
   const RequiresValidationTestData test = GetParam();
 
   base::Time request_time, response_time, current_time;
-  base::Time::FromString("Wed, 28 Nov 2007 00:40:09 GMT", &request_time);
-  base::Time::FromString("Wed, 28 Nov 2007 00:40:12 GMT", &response_time);
-  base::Time::FromString("Wed, 28 Nov 2007 00:45:20 GMT", &current_time);
+  ignore_result(
+      base::Time::FromString("Wed, 28 Nov 2007 00:40:09 GMT", &request_time));
+  ignore_result(
+      base::Time::FromString("Wed, 28 Nov 2007 00:40:12 GMT", &response_time));
+  ignore_result(
+      base::Time::FromString("Wed, 28 Nov 2007 00:45:20 GMT", &current_time));

[mmenke, 2017/01/03 15:39:24]

Should these all be ASSERT_TRUE?

[digit1, 2017/01/03 16:44:53]

Yes, that sounds more logical, I've uploaded a new patchset that does this.
Thanks.

 
   std::string headers(test.headers);
   HeadersToRaw(&headers);
   scoped_refptr<HttpResponseHeaders> parsed(new HttpResponseHeaders(headers));
 
   ValidationType validation_type =
       parsed->RequiresValidation(request_time, response_time, current_time);
   EXPECT_EQ(test.validation_type, validation_type);
 }
 
@@ skipping 1335 matching lines @@
 TEST_F(HttpResponseHeadersCacheControlTest,
        FirstStaleWhileRevalidateValueUsed) {
   InitializeHeadersWithCacheControl(
       "stale-while-revalidate=1,stale-while-revalidate=7200");
   EXPECT_EQ(TimeDelta::FromSeconds(1), GetStaleWhileRevalidateValue());
 }
 
 }  // namespace
 
 }  // namespace net