[Android] Change items shown in context meanu for mailto link

[Android] Change items shown in context meanu for mailto link

Current items (Open in new tab, Open in incognito tab, Copy link
address, Copy link text) shown in the context menu for mailto tag link
do not make sense.

Update the items shown in the context menu when long pressing a mailto
link. The items include:
1. Send message: same behavior as clicking the link which will navigate
to default mail app to send an email with parsed info from url.
2. Add to contacts:
  - If no email address in the mailto, hid the menu item
  - If more than one email addresses is present, select the first one
    for adding to the contacts
3. Copy: copy all the email addresses (everything between mailto: and ?)

BUG=389056
Review-Url: https://codereview.chromium.org/2605283002
Cr-Commit-Position: refs/heads/master@{#442086}
Committed: https://chromium.googlesource.com/chromium/src/+/494e85acc477fced01f74b404f4d1c1c0a81a9fe

[ltian, 2016-12-29 16:11:40]

The CQ bit was checked by ltian@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-29 16:11:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-29 17:06:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-29 17:06:55]

Dry run: This issue passed the CQ dry run.

[ltian, 2016-12-29 17:17:17]

tedchoc@chromium.org: can you take a look of my changes in this CL?

Thanks!

[ltian, 2016-12-29 17:18:54]

ltian@chromium.org changed reviewers:
+ tedchoc@chromium.org

[ltian, 2016-12-29 17:18:54]

tedchoc@chromium.org: can you take a look of my changes in this CL?

Thanks!

[Ted C, 2017-01-03 23:19:24]

https://codereview.chromium.org/2605283002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
(right):

https://codereview.chromium.org/2605283002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java:222:
if (MailTo.parse(params.getLinkUrl()).getTo() == null) {
I would use !TextUtils.isEmpty(...)

https://codereview.chromium.org/2605283002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java:226:
menu.setGroupVisible(R.id.contextmenu_group_email, false);
for send message and add to contacts, I think we want to hide the items if
activities aren't available.

Maybe to the delegate, you should add supportsSendEmailMessage,
supportsAddToContacts.

Then for both you can construct "dummy" intents and pass them to
WindowAndroid#canResolveActivity.  If they resolve, then an activity is on the
device that can handle it.  If not, we should hide the items.

You might be able to test this locally by disabling the apps on the phone (but I
don't know if Android will return disabled apps or not).

https://codereview.chromium.org/2605283002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java
(right):

https://codereview.chromium.org/2605283002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java:81:
Intent i = new Intent(Intent.ACTION_VIEW);
I would add .setFlags(Intent.FLAG_ACTIVITY_NEW_TASK); here and below.

https://codereview.chromium.org/2605283002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java:83:
mTab.getActivity().startActivity(i);
I would use IntentUtils.safeStartActivity here

https://codereview.chromium.org/2605283002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java:91:
ContactsContract.Intents.Insert.EMAIL, MailTo.parse(url).getTo().split(",")[0]);
looking at the contract, it supports 3 emails so I think we should probably do
that as well

https://developer.android.com/reference/android/provider/ContactsContract.Int...
https://developer.android.com/reference/android/provider/ContactsContract.Int...

Looks like it might support an arbitrary number as well if we were to use:
https://developer.android.com/reference/android/provider/ContactsContract.Int...

Maybe check that out to see if that is possible.

https://codereview.chromium.org/2605283002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java
(right):

https://codereview.chromium.org/2605283002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java:257:
"someone1@example.com,someone2@example.com", getClipboardText());
why did this change?  I don't see any code changes that updated what we copied.

[ltian, 2017-01-04 01:51:41]

The CQ bit was checked by ltian@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 01:51:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 02:46:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 02:46:38]

Dry run: This issue passed the CQ dry run.

[ltian, 2017-01-04 03:07:19]

https://codereview.chromium.org/2605283002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
(right):

https://codereview.chromium.org/2605283002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java:222:
if (MailTo.parse(params.getLinkUrl()).getTo() == null) {
On 2017/01/03 23:19:24, Ted C wrote:
> I would use !TextUtils.isEmpty(...)

Done.

https://codereview.chromium.org/2605283002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java:226:
menu.setGroupVisible(R.id.contextmenu_group_email, false);
On 2017/01/03 23:19:24, Ted C wrote:
> for send message and add to contacts, I think we want to hide the items if
> activities aren't available.
> 
> Maybe to the delegate, you should add supportsSendEmailMessage,
> supportsAddToContacts.
> 
> Then for both you can construct "dummy" intents and pass them to
> WindowAndroid#canResolveActivity.  If they resolve, then an activity is on the
> device that can handle it.  If not, we should hide the items.
> 
> You might be able to test this locally by disabling the apps on the phone (but
I
> don't know if Android will return disabled apps or not).

Done.

https://codereview.chromium.org/2605283002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java
(right):

https://codereview.chromium.org/2605283002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java:81:
Intent i = new Intent(Intent.ACTION_VIEW);
On 2017/01/03 23:19:24, Ted C wrote:
> I would add .setFlags(Intent.FLAG_ACTIVITY_NEW_TASK); here and below.

Done.

https://codereview.chromium.org/2605283002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java:83:
mTab.getActivity().startActivity(i);
On 2017/01/03 23:19:24, Ted C wrote:
> I would use IntentUtils.safeStartActivity here

Done.

https://codereview.chromium.org/2605283002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java:91:
ContactsContract.Intents.Insert.EMAIL, MailTo.parse(url).getTo().split(",")[0]);
On 2017/01/03 23:19:24, Ted C wrote:
> looking at the contract, it supports 3 emails so I think we should probably do
> that as well
> 
>
https://developer.android.com/reference/android/provider/ContactsContract.Int...
>
https://developer.android.com/reference/android/provider/ContactsContract.Int...
> 
> Looks like it might support an arbitrary number as well if we were to use:
>
https://developer.android.com/reference/android/provider/ContactsContract.Int...
> 
> Maybe check that out to see if that is possible.

I check and it could add an arbitrary number of emails but the only problem is
all the emails will be added to the same account (same when we set
SECONDARY_EMAIL and TERTIARY_EMAIL). My thought is when there are multiple
emails, there should be from different people and we should not add them into
same account?

The UX design also chooses only to add the first email, I guess it has the same
concern?

https://codereview.chromium.org/2605283002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java
(right):

https://codereview.chromium.org/2605283002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java:257:
"someone1@example.com,someone2@example.com", getClipboardText());
On 2017/01/03 23:19:24, Ted C wrote:
> why did this change?  I don't see any code changes that updated what we
copied.

The copy behavior should copy all the emails if there are multiple emails for
mailto tag. So I change the
chrome/test/data/android/contextmenu/context_menu_test.html file's mailto link
by adding multiple emails and then the behavior here.

[Ted C, 2017-01-04 18:40:08]

Were you able to test with the apps disabled?  Wondering if that works and you
were able to verify the context menu items were correctly hidden?

https://codereview.chromium.org/2605283002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java
(right):

https://codereview.chromium.org/2605283002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java:91:
ContactsContract.Intents.Insert.EMAIL, MailTo.parse(url).getTo().split(",")[0]);
On 2017/01/04 03:07:19, ltian wrote:
> On 2017/01/03 23:19:24, Ted C wrote:
> > looking at the contract, it supports 3 emails so I think we should probably
do
> > that as well
> > 
> >
>
https://developer.android.com/reference/android/provider/ContactsContract.Int...
> >
>
https://developer.android.com/reference/android/provider/ContactsContract.Int...
> > 
> > Looks like it might support an arbitrary number as well if we were to use:
> >
>
https://developer.android.com/reference/android/provider/ContactsContract.Int...
> > 
> > Maybe check that out to see if that is possible.
> 
> I check and it could add an arbitrary number of emails but the only problem is
> all the emails will be added to the same account (same when we set
> SECONDARY_EMAIL and TERTIARY_EMAIL). My thought is when there are multiple
> emails, there should be from different people and we should not add them into
> same account?
> 
> The UX design also chooses only to add the first email, I guess it has the
same
> concern?

Ah ok, let's just do the first one since that was what was agreed upon.

https://codereview.chromium.org/2605283002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
(right):

https://codereview.chromium.org/2605283002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java:228:
if (TextUtils.isEmpty(MailTo.parse(params.getLinkUrl()).getTo())) {
I would || this with the condition above.

https://codereview.chromium.org/2605283002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuItemDelegate.java
(right):

https://codereview.chromium.org/2605283002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuItemDelegate.java:110:
void onSendMessage(String url);
let's rename this to onSendEmailMessage to make it clearer and match
supportsSendEmailMessage above.

https://codereview.chromium.org/2605283002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java
(right):

https://codereview.chromium.org/2605283002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java:84:
intent.setData(Uri.parse("mailto:test@google.com"));
Tiny nit. Let's use @example.com to not make this google specific.

https://codereview.chromium.org/2605283002/diff/20001/chrome/android/java/str...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/2605283002/diff/20001/chrome/android/java/str...
chrome/android/java/strings/android_chrome_strings.grd:1454: <message
name="IDS_CONTEXTMENU_SEND_MESSAGE" desc="Context sensitive menu item for
sending message. [CHAR-LIMIT=30]">
for sending [an email] message

https://codereview.chromium.org/2605283002/diff/20001/chrome/android/java/str...
chrome/android/java/strings/android_chrome_strings.grd:1457: <message
name="IDS_CONTEXTMENU_ADD_TO_CONTACTS" desc="Context sensitive menu item for
adding email address to contacts. [CHAR-LIMIT=30]">
adding [an] email

[ltian, 2017-01-04 20:39:40]

On 2017/01/04 18:40:08, Ted C wrote:
> Were you able to test with the apps disabled?  Wondering if that works and you
> were able to verify the context menu items were correctly hidden?

Yes, by disabling the Contacts and Gmail app, the context menus for "Add to
contact" and "Send message" are disppeared.
> 
>
https://codereview.chromium.org/2605283002/diff/1/chrome/android/java/src/org...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java
> (right):
> 
>
https://codereview.chromium.org/2605283002/diff/1/chrome/android/java/src/org...
>
chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java:91:
> ContactsContract.Intents.Insert.EMAIL,
MailTo.parse(url).getTo().split(",")[0]);
> On 2017/01/04 03:07:19, ltian wrote:
> > On 2017/01/03 23:19:24, Ted C wrote:
> > > looking at the contract, it supports 3 emails so I think we should
probably
> do
> > > that as well
> > > 
> > >
> >
>
https://developer.android.com/reference/android/provider/ContactsContract.Int...
> > >
> >
>
https://developer.android.com/reference/android/provider/ContactsContract.Int...
> > > 
> > > Looks like it might support an arbitrary number as well if we were to use:
> > >
> >
>
https://developer.android.com/reference/android/provider/ContactsContract.Int...
> > > 
> > > Maybe check that out to see if that is possible.
> > 
> > I check and it could add an arbitrary number of emails but the only problem
is
> > all the emails will be added to the same account (same when we set
> > SECONDARY_EMAIL and TERTIARY_EMAIL). My thought is when there are multiple
> > emails, there should be from different people and we should not add them
into
> > same account?
> > 
> > The UX design also chooses only to add the first email, I guess it has the
> same
> > concern?
> 
> Ah ok, let's just do the first one since that was what was agreed upon.
> 
>
https://codereview.chromium.org/2605283002/diff/20001/chrome/android/java/src...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
> (right):
> 
>
https://codereview.chromium.org/2605283002/diff/20001/chrome/android/java/src...
>
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java:228:
> if (TextUtils.isEmpty(MailTo.parse(params.getLinkUrl()).getTo())) {
> I would || this with the condition above.
> 
>
https://codereview.chromium.org/2605283002/diff/20001/chrome/android/java/src...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuItemDelegate.java
> (right):
> 
>
https://codereview.chromium.org/2605283002/diff/20001/chrome/android/java/src...
>
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuItemDelegate.java:110:
> void onSendMessage(String url);
> let's rename this to onSendEmailMessage to make it clearer and match
> supportsSendEmailMessage above.
> 
>
https://codereview.chromium.org/2605283002/diff/20001/chrome/android/java/src...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java
> (right):
> 
>
https://codereview.chromium.org/2605283002/diff/20001/chrome/android/java/src...
>
chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java:84:
> intent.setData(Uri.parse("mailto:test@google.com"));
> Tiny nit. Let's use @example.com to not make this google specific.
> 
>
https://codereview.chromium.org/2605283002/diff/20001/chrome/android/java/str...
> File chrome/android/java/strings/android_chrome_strings.grd (right):
> 
>
https://codereview.chromium.org/2605283002/diff/20001/chrome/android/java/str...
> chrome/android/java/strings/android_chrome_strings.grd:1454: <message
> name="IDS_CONTEXTMENU_SEND_MESSAGE" desc="Context sensitive menu item for
> sending message. [CHAR-LIMIT=30]">
> for sending [an email] message
> 
>
https://codereview.chromium.org/2605283002/diff/20001/chrome/android/java/str...
> chrome/android/java/strings/android_chrome_strings.grd:1457: <message
> name="IDS_CONTEXTMENU_ADD_TO_CONTACTS" desc="Context sensitive menu item for
> adding email address to contacts. [CHAR-LIMIT=30]">
> adding [an] email

[ltian, 2017-01-04 20:46:59]

https://codereview.chromium.org/2605283002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
(right):

https://codereview.chromium.org/2605283002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java:228:
if (TextUtils.isEmpty(MailTo.parse(params.getLinkUrl()).getTo())) {
On 2017/01/04 18:40:08, Ted C wrote:
> I would || this with the condition above.

Done.

https://codereview.chromium.org/2605283002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuItemDelegate.java
(right):

https://codereview.chromium.org/2605283002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuItemDelegate.java:110:
void onSendMessage(String url);
On 2017/01/04 18:40:08, Ted C wrote:
> let's rename this to onSendEmailMessage to make it clearer and match
> supportsSendEmailMessage above.

Done.

https://codereview.chromium.org/2605283002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java
(right):

https://codereview.chromium.org/2605283002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java:84:
intent.setData(Uri.parse("mailto:test@google.com"));
On 2017/01/04 18:40:08, Ted C wrote:
> Tiny nit. Let's use @example.com to not make this google specific.

Done.

https://codereview.chromium.org/2605283002/diff/20001/chrome/android/java/str...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/2605283002/diff/20001/chrome/android/java/str...
chrome/android/java/strings/android_chrome_strings.grd:1454: <message
name="IDS_CONTEXTMENU_SEND_MESSAGE" desc="Context sensitive menu item for
sending message. [CHAR-LIMIT=30]">
On 2017/01/04 18:40:08, Ted C wrote:
> for sending [an email] message

Done.

https://codereview.chromium.org/2605283002/diff/20001/chrome/android/java/str...
chrome/android/java/strings/android_chrome_strings.grd:1457: <message
name="IDS_CONTEXTMENU_ADD_TO_CONTACTS" desc="Context sensitive menu item for
adding email address to contacts. [CHAR-LIMIT=30]">
On 2017/01/04 18:40:08, Ted C wrote:
> adding [an] email

Done.

[Ted C, 2017-01-04 21:18:50]

lgtm w/ a couple last comments.  You'll need to get an owners approval for
histograms.xml as well.

https://codereview.chromium.org/2605283002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
(right):

https://codereview.chromium.org/2605283002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java:109:
static final int ACTION_ADD_TO_CONTACTS = 22;
from the comment above, you need to update ContextMenuOption in histograms.xml
as part of this change as well.

https://codereview.chromium.org/2605283002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java
(right):

https://codereview.chromium.org/2605283002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java:32:

unnecessary blank space

[ltian, 2017-01-04 23:18:57]

ltian@chromium.org changed reviewers:
+ ericwilligers@chromium.org

[ltian, 2017-01-04 23:18:57]

ericwilligers@chromium.org: Can you take a look of my changes for
histograms.xml?

https://codereview.chromium.org/2605283002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
(right):

https://codereview.chromium.org/2605283002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java:109:
static final int ACTION_ADD_TO_CONTACTS = 22;
On 2017/01/04 21:18:50, Ted C wrote:
> from the comment above, you need to update ContextMenuOption in histograms.xml
> as part of this change as well.

Done.

https://codereview.chromium.org/2605283002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java
(right):

https://codereview.chromium.org/2605283002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java:32:

On 2017/01/04 21:18:50, Ted C wrote:
> unnecessary blank space

Done.

[ltian, 2017-01-04 23:37:42]

The CQ bit was checked by ltian@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 23:38:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eric Willigers, 2017-01-04 23:45:16]

ericwilligers@chromium.org changed reviewers:
+ isherman@chromium.org

[Eric Willigers, 2017-01-04 23:45:16]

+isherman for histogram changes.

[Eric Willigers, 2017-01-04 23:46:01]

ericwilligers@chromium.org changed reviewers:
+ jwd@chromium.org
- isherman@chromium.org

[Eric Willigers, 2017-01-04 23:46:45]

On 2017/01/04 23:45:16, Eric Willigers wrote:
> +isherman for histogram changes.

+jwd as isherman is away

[commit-bot: I haz the power, 2017-01-05 01:43:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 01:43:53]

Dry run: This issue passed the CQ dry run.

[jwd, 2017-01-06 15:11:58]

histograms LGTM

[ltian, 2017-01-06 19:10:07]

On 2017/01/06 15:11:58, jwd wrote:
> histograms LGTM

@ericwilligers: could you also review the histogram changes, it seems I still
need lgtm for histograms.xml from you.

Thanks!

[ltian, 2017-01-06 21:58:56]

On 2017/01/06 19:10:07, ltian wrote:
> On 2017/01/06 15:11:58, jwd wrote:
> > histograms LGTM
> 
> @ericwilligers: could you also review the histogram changes, it seems I still
> need lgtm for histograms.xml from you.
> 
> Thanks!

Never mind. It seems I use an extension which provides me wrong information
about OWNER info. Sorry for that!

[ltian, 2017-01-06 21:59:05]

The CQ bit was checked by ltian@chromium.org

[ltian, 2017-01-06 21:59:06]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2605283002/#ps80001
(title: "Update label for send email action to clearly state send email instead
of send message.")

[commit-bot: I haz the power, 2017-01-06 21:59:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 23:09:45]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1483739945864160,
"parent_rev": "a576f652af13438c3867a306ce847e87585dcb7b", "commit_rev":
"494e85acc477fced01f74b404f4d1c1c0a81a9fe"}

[commit-bot: I haz the power, 2017-01-06 23:10:16]

Description was changed from

==========
[Android] Change items shown in context meanu for mailto link

Current items (Open in new tab, Open in incognito tab, Copy link
address, Copy link text) shown in the context menu for mailto tag link
do not make sense.

Update the items shown in the context menu when long pressing a mailto
link. The items include:
1. Send message: same behavior as clicking the link which will navigate
to default mail app to send an email with parsed info from url.
2. Add to contacts:
  - If no email address in the mailto, hid the menu item
  - If more than one email addresses is present, select the first one
    for adding to the contacts
3. Copy: copy all the email addresses (everything between mailto: and ?)

BUG=389056
==========

to

==========
[Android] Change items shown in context meanu for mailto link

Current items (Open in new tab, Open in incognito tab, Copy link
address, Copy link text) shown in the context menu for mailto tag link
do not make sense.

Update the items shown in the context menu when long pressing a mailto
link. The items include:
1. Send message: same behavior as clicking the link which will navigate
to default mail app to send an email with parsed info from url.
2. Add to contacts:
  - If no email address in the mailto, hid the menu item
  - If more than one email addresses is present, select the first one
    for adding to the contacts
3. Copy: copy all the email addresses (everything between mailto: and ?)

BUG=389056

Review-Url: https://codereview.chromium.org/2605283002
Cr-Commit-Position: refs/heads/master@{#442086}
Committed:
https://chromium.googlesource.com/chromium/src/+/494e85acc477fced01f74b404f4d...
==========

[commit-bot: I haz the power, 2017-01-06 23:10:17]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/494e85acc477fced01f74b404f4d...

[Ilya Sherman, 2017-01-07 00:46:48]

isherman@chromium.org changed reviewers:
+ isherman@chromium.org

[Ilya Sherman, 2017-01-07 00:46:48]

histograms.xml lgtm