Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2605273003: Don't use DF text during animations (Closed)

Created:
3 years, 11 months ago by ericrk
Modified:
3 years, 11 months ago
Reviewers:
ajuma
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't use DF text during animations Previously, we enabled distance-field text during animations in order to improve GPU raster performance. Now that GPU raster handles animations the same way as SW - only rastering at specific scales and interpolating, this optimization isn't necessary. In certain cases, the optimization causes visual differences between non-animating and animating content, so removing this improves our correctness as well. R=ajuma@chromium.org BUG=668723 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Committed: https://crrev.com/b04a4a62bc244a238e63c6862be0ed6dfe84a837 Cr-Commit-Position: refs/heads/master@{#441204}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -32 lines) Patch
M cc/layers/picture_layer_impl.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/playback/raster_source.h View 2 chunks +0 lines, -11 lines 0 comments Download
M cc/playback/raster_source.cc View 3 chunks +0 lines, -11 lines 0 comments Download
M cc/raster/gpu_raster_buffer_provider.cc View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
ericrk
3 years, 11 months ago (2016-12-30 01:04:59 UTC) #3
ajuma
lgtm, thanks for the fix!
3 years, 11 months ago (2017-01-02 20:43:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2605273003/1
3 years, 11 months ago (2017-01-03 19:47:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-03 20:48:38 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 20:51:10 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b04a4a62bc244a238e63c6862be0ed6dfe84a837
Cr-Commit-Position: refs/heads/master@{#441204}

Powered by Google App Engine
This is Rietveld 408576698