Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Issue 2605273002: DialogDelegate unittests: Remove dead code. (Closed)

Created:
3 years, 11 months ago by karandeepb
Modified:
3 years, 11 months ago
Reviewers:
msw
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DialogDelegate unittests: Remove dead code. This CL removes some dead code from dialog_delegate_unittest.cc. r206950 made the TestDialog class a ButtonListener and added the last_pressed_button() method. However r372427 removed the last usages of TestDialog as a ButtonListener. This CL modifies TestDialog to not be a ButtonListener anymore and removes the associated dead code. BUG=NONE Committed: https://crrev.com/dc037e9dc73407de119ceebd14b07102fad9b261 Cr-Commit-Position: refs/heads/master@{#440970}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -20 lines) Patch
M ui/views/window/dialog_delegate_unittest.cc View 5 chunks +8 lines, -20 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (10 generated)
karandeepb
PTAL msw@.
3 years, 11 months ago (2016-12-29 15:09:13 UTC) #7
msw
lgtm
3 years, 11 months ago (2016-12-29 18:00:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2605273002/1
3 years, 11 months ago (2016-12-29 18:03:42 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-29 18:07:37 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:52:45 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dc037e9dc73407de119ceebd14b07102fad9b261
Cr-Commit-Position: refs/heads/master@{#440970}

Powered by Google App Engine
This is Rietveld 408576698