Tolerate subpixel differences in checkPaintInvalidationVisualRect()

Tolerate subpixel differences in checkPaintInvalidationVisualRect()

We snap visual rect to pixels differently in different paths, so ignore
the subpixel differences.

This fixes failure of VisualRectMappingTest.LayoutText on mac with patch
https://codereview.chromium.org/2595323003/#ps160001

BUG=646176
Committed: https://crrev.com/35de3fad300c4cc9e44d61aa41919989819dbd78
Cr-Commit-Position: refs/heads/master@{#440915}

[Xianzhu, 2016-12-28 23:23:38]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org

[chrishtr, 2016-12-28 23:31:56]

Is the mac-specific failure because we fail to use a platform-independent theme
in the test?

[Xianzhu, 2016-12-28 23:44:29]

On 2016/12/28 23:31:56, chrishtr wrote:
> Is the mac-specific failure because we fail to use a platform-independent
theme
> in the test?

I think it's because of different fonts. Even if we make the font
platform-independent, the difference in subpixel handling still exists and needs
to be addressed.

[chrishtr, 2016-12-28 23:47:06]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-12-28 23:47:06]

lgtm

[commit-bot: I haz the power, 2016-12-28 23:47:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-29 00:52:32]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482968826322830, "parent_rev":
"3622a6640d8709e49186ba7c3fb7ccd90e2aa510", "commit_rev":
"6af82441b8ec93123d5efa54c2ee53e63d34499e"}

[commit-bot: I haz the power, 2016-12-29 00:52:58]

Description was changed from

==========
Tolerate subpixel differences in checkPaintInvalidationVisualRect()

We snap visual rect to pixels differently in different paths, so ignore
the subpixel differences.

This fixes failure of VisualRectMappingTest.LayoutText on mac with patch
https://codereview.chromium.org/2595323003/#ps160001

BUG=646176
==========

to

==========
Tolerate subpixel differences in checkPaintInvalidationVisualRect()

We snap visual rect to pixels differently in different paths, so ignore
the subpixel differences.

This fixes failure of VisualRectMappingTest.LayoutText on mac with patch
https://codereview.chromium.org/2595323003/#ps160001

BUG=646176

Review-Url: https://codereview.chromium.org/2605163002
==========

[commit-bot: I haz the power, 2016-12-29 00:53:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2017-01-02 15:51:02]

Description was changed from

==========
Tolerate subpixel differences in checkPaintInvalidationVisualRect()

We snap visual rect to pixels differently in different paths, so ignore
the subpixel differences.

This fixes failure of VisualRectMappingTest.LayoutText on mac with patch
https://codereview.chromium.org/2595323003/#ps160001

BUG=646176

Review-Url: https://codereview.chromium.org/2605163002
==========

to

==========
Tolerate subpixel differences in checkPaintInvalidationVisualRect()

We snap visual rect to pixels differently in different paths, so ignore
the subpixel differences.

This fixes failure of VisualRectMappingTest.LayoutText on mac with patch
https://codereview.chromium.org/2595323003/#ps160001

BUG=646176

Committed: https://crrev.com/35de3fad300c4cc9e44d61aa41919989819dbd78
Cr-Commit-Position: refs/heads/master@{#440915}
==========

[commit-bot: I haz the power, 2017-01-02 15:51:03]

Patchset 1 (id:??) landed as
https://crrev.com/35de3fad300c4cc9e44d61aa41919989819dbd78
Cr-Commit-Position: refs/heads/master@{#440915}