[Findit] Adding schedule_flake_try_job_pipeline.py to trigger flake try jobs

[Findit] Adding schedule_flake_try_job_pipeline.py to trigger flake try jobs

Sample try job resulting from running this pipeline: https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_variable/builds/553

BUG=672724
Review-Url: https://codereview.chromium.org/2605153002
Committed: https://chromium.googlesource.com/infra/infra/+/27f322001fe1b25d59f755eea46c413ac12fd418

[lijeffrey, 2016-12-28 23:33:31]

Description was changed from

==========
[Findit] Adding schedule_flake_try_job_pipeline.py to trigger flake try jobs

BUG=
==========

to

==========
[Findit] Adding schedule_flake_try_job_pipeline.py to trigger flake try jobs

BUG=
==========

[lijeffrey, 2016-12-28 23:33:31]

lijeffrey@chromium.org changed reviewers:
+ chanli@chromium.org, robertocn@chromium.org, stgao@chromium.org

[lijeffrey, 2016-12-28 23:34:24]

This CL has a few other changes from other CLs that have not been committed yet.
The only ones of intrest are schedule_flake_try_job_pipeline.py and
schedule_flake_try_job_pipeline_test.py. Once the other CLs are committed this
one can be rebased to simplify this one's review.

Roberto, can you ptal that the fields being passed are as expected in
schedule_flake_try_job_pipeline.py?

Thanks,
Jeff

[RobertoCN, 2016-12-29 00:19:23]

https://codereview.chromium.org/2605153002/diff/1/appengine/findit/waterfall/...
File appengine/findit/waterfall/flake/schedule_flake_try_job_pipeline.py
(right):

https://codereview.chromium.org/2605153002/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/flake/schedule_flake_try_job_pipeline.py:18:
'iterations_to_rerun', 100)
This is already defaulted to 100 in the recipe. I don't think it's a big deal,
but having two sources of truth might get confusing at some point.

https://codereview.chromium.org/2605153002/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/flake/schedule_flake_try_job_pipeline.py:24:
'test_revision': git_hash,
The key has been renamed to just 'revision'

https://codereview.chromium.org/2605153002/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/flake/schedule_flake_try_job_pipeline.py:25:
'flakiness_tests': iterations,
Renamed to 'test_repeat_count' with a default value of 100

[lijeffrey, 2016-12-29 00:29:51]

https://codereview.chromium.org/2605153002/diff/1/appengine/findit/waterfall/...
File appengine/findit/waterfall/flake/schedule_flake_try_job_pipeline.py
(right):

https://codereview.chromium.org/2605153002/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/flake/schedule_flake_try_job_pipeline.py:18:
'iterations_to_rerun', 100)
On 2016/12/29 00:19:23, RobertoCN wrote:
> This is already defaulted to 100 in the recipe. I don't think it's a big deal,
> but having two sources of truth might get confusing at some point.

Done.

https://codereview.chromium.org/2605153002/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/flake/schedule_flake_try_job_pipeline.py:24:
'test_revision': git_hash,
On 2016/12/29 00:19:23, RobertoCN wrote:
> The key has been renamed to just 'revision'

Done.

https://codereview.chromium.org/2605153002/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/flake/schedule_flake_try_job_pipeline.py:25:
'flakiness_tests': iterations,
On 2016/12/29 00:19:23, RobertoCN wrote:
> Renamed to 'test_repeat_count' with a default value of 100

Done.

[lijeffrey, 2016-12-29 23:09:54]

per discussion with Roberto, the field 'revision' has been renamed back to
'test_revision' per https://chromium-review.googlesource.com/#/c/424145/

[lijeffrey, 2016-12-30 00:22:52]

Description was changed from

==========
[Findit] Adding schedule_flake_try_job_pipeline.py to trigger flake try jobs

BUG=
==========

to

==========
[Findit] Adding schedule_flake_try_job_pipeline.py to trigger flake try jobs

Sample try job resulting from running this pipeline:
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_var...

BUG=
==========

[lijeffrey, 2016-12-30 00:24:00]

Description was changed from

==========
[Findit] Adding schedule_flake_try_job_pipeline.py to trigger flake try jobs

Sample try job resulting from running this pipeline:
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_var...

BUG=
==========

to

==========
[Findit] Adding schedule_flake_try_job_pipeline.py to trigger flake try jobs

Sample try job resulting from running this pipeline:
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_var...

BUG=672724
==========

[stgao, 2017-01-10 05:56:02]

lgtm % comments

But I'd like Chan to review this CL too.

https://codereview.chromium.org/2605153002/diff/60001/appengine/findit/waterf...
File appengine/findit/waterfall/flake/schedule_flake_try_job_pipeline.py
(right):

https://codereview.chromium.org/2605153002/diff/60001/appengine/findit/waterf...
appengine/findit/waterfall/flake/schedule_flake_try_job_pipeline.py:1: #
Copyright 2016 The Chromium Authors. All rights reserved.
nit: 2017

https://codereview.chromium.org/2605153002/diff/60001/appengine/findit/waterf...
appengine/findit/waterfall/flake/schedule_flake_try_job_pipeline.py:41:
builder_name (str): the builder name of a flaky test.
nit: the -> The

https://codereview.chromium.org/2605153002/diff/60001/appengine/findit/waterf...
appengine/findit/waterfall/flake/schedule_flake_try_job_pipeline.py:42:
step_name (str): The name of the step the flaky test occurred on.
Should it be test_target or step_name?

@chanli: what's the one in the try-job for reliable test failure?

[lijeffrey, 2017-01-10 09:32:07]

https://codereview.chromium.org/2605153002/diff/60001/appengine/findit/waterf...
File appengine/findit/waterfall/flake/schedule_flake_try_job_pipeline.py
(right):

https://codereview.chromium.org/2605153002/diff/60001/appengine/findit/waterf...
appengine/findit/waterfall/flake/schedule_flake_try_job_pipeline.py:1: #
Copyright 2016 The Chromium Authors. All rights reserved.
On 2017/01/10 05:56:02, stgao (slow on Monday) wrote:
> nit: 2017

Done.

https://codereview.chromium.org/2605153002/diff/60001/appengine/findit/waterf...
appengine/findit/waterfall/flake/schedule_flake_try_job_pipeline.py:41:
builder_name (str): the builder name of a flaky test.
On 2017/01/10 05:56:02, stgao (slow on Monday) wrote:
> nit: the -> The

Done.

[chanli, 2017-01-10 18:57:53]

lgtm

[lijeffrey, 2017-01-10 22:34:50]

The CQ bit was checked by lijeffrey@chromium.org

[lijeffrey, 2017-01-10 22:34:51]

The patchset sent to the CQ was uploaded after l-g-t-m from stgao@chromium.org
Link to the patchset: https://codereview.chromium.org/2605153002/#ps100001
(title: "Fixing unintentional change")

[commit-bot: I haz the power, 2017-01-10 22:35:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 22:45:00]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1484087690774780,
"parent_rev": "16378935703e1f87a41d45e72b02b790c233074d", "commit_rev":
"27f322001fe1b25d59f755eea46c413ac12fd418"}

[commit-bot: I haz the power, 2017-01-10 22:45:03]

Description was changed from

==========
[Findit] Adding schedule_flake_try_job_pipeline.py to trigger flake try jobs

Sample try job resulting from running this pipeline:
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_var...

BUG=672724
==========

to

==========
[Findit] Adding schedule_flake_try_job_pipeline.py to trigger flake try jobs

Sample try job resulting from running this pipeline:
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_var...

BUG=672724

Review-Url: https://codereview.chromium.org/2605153002
Committed:
https://chromium.googlesource.com/infra/infra/+/27f322001fe1b25d59f755eea46c4...
==========

[commit-bot: I haz the power, 2017-01-10 22:45:04]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/infra/infra/+/27f322001fe1b25d59f755eea46c4...