Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2605103004: Add names to layout test results.html unit tests. (Closed)

Created:
3 years, 11 months ago by qyearsley
Modified:
3 years, 11 months ago
Reviewers:
jeffcarp, ojan
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add names to layout test results.html unit tests. The purpose of this CL is to make it easier to edit results.html by making it clearer which unit tests are failing. This may make it slightly easier to work on http://crbug.com/664274. Review-Url: https://codereview.chromium.org/2605103004 Cr-Commit-Position: refs/heads/master@{#443433} Committed: https://chromium.googlesource.com/chromium/src/+/0864b23c064436084062af546b78e03e0c4f0e5e

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Update harness/results-expected.txt. #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+303 lines, -296 lines) Patch
M third_party/WebKit/LayoutTests/fast/harness/resources/results-test.js View 1 2 3 36 chunks +54 lines, -47 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/harness/results-expected.txt View 1 2 3 1 chunk +249 lines, -249 lines 0 comments Download

Messages

Total messages: 23 (17 generated)
qyearsley
3 years, 11 months ago (2016-12-29 19:35:22 UTC) #2
qyearsley
ojan@: this is a minor/non-urgent CL, and now results-expected.txt has been updated so we can ...
3 years, 11 months ago (2017-01-10 23:57:52 UTC) #9
qyearsley
This was a change I made at the end of December when looking at fast/harness/results.html. ...
3 years, 11 months ago (2017-01-12 22:37:41 UTC) #13
jeffcarp
lgtm
3 years, 11 months ago (2017-01-13 00:52:04 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2605103004/60001
3 years, 11 months ago (2017-01-13 01:16:49 UTC) #20
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 01:26:59 UTC) #23
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/0864b23c064436084062af546b78...

Powered by Google App Engine
This is Rietveld 408576698