Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2605103003:
Remove unnecessary v8:: prefixes in include/v8.h (Closed)
|
Created:
3 years, 11 months ago by Devlin Modified:
3 years, 11 months ago Reviewers:
jochen (gone - plz use gerrit) CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionRemove unnecessary v8:: prefixes in include/v8.h
Remove a bunch of unnecessary v8:: prefixes in include/v8.h.
Some are still necessary for disambiguation purposes (e.g., between
bool Value() and v8::Value, or between v8::Isolate and
v8::internal::Isolate), but many aren't.
BUG=None
Review-Url: https://codereview.chromium.org/2605103003
Cr-Commit-Position: refs/heads/master@{#42071}
Committed: https://chromium.googlesource.com/v8/v8/+/f81590a1c8344cf87e72e312722abe0b35d9601f
Patch Set 1 : . #Patch Set 2 : . #Messages
Total messages: 19 (13 generated)
Description was changed from ========== Remove v8:: prefix BUG= ========== to ========== Remove unnecessary v8:: prefixes in include/v8.h Remove a bunch of unnecessary v8:: prefixes in include/v8.h. Some are still necessary for disambiguation purposes (e.g., between bool Value() and v8::Value, or between v8::Isolate and v8::internal::Isolate), but many aren't. BUG=None ==========
Patchset #1 (id:1) has been deleted
rdevlin.cronin@chromium.org changed reviewers: + jochen@chromium.org
jochen, mind taking a look when you're back in? (I was mostly just looking to experiment with a v8 checkout and contribution.)
lgtm
The CQ bit was checked by rdevlin.cronin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...) v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by rdevlin.cronin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org Link to the patchset: https://codereview.chromium.org/2605103003/#ps40001 (title: ".")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483549510184580,
"parent_rev": "81dc09fb98661a59c51d7736a281ef251ffea033", "commit_rev":
"f81590a1c8344cf87e72e312722abe0b35d9601f"}
Message was sent while issue was closed.
Description was changed from ========== Remove unnecessary v8:: prefixes in include/v8.h Remove a bunch of unnecessary v8:: prefixes in include/v8.h. Some are still necessary for disambiguation purposes (e.g., between bool Value() and v8::Value, or between v8::Isolate and v8::internal::Isolate), but many aren't. BUG=None ========== to ========== Remove unnecessary v8:: prefixes in include/v8.h Remove a bunch of unnecessary v8:: prefixes in include/v8.h. Some are still necessary for disambiguation purposes (e.g., between bool Value() and v8::Value, or between v8::Isolate and v8::internal::Isolate), but many aren't. BUG=None Review-Url: https://codereview.chromium.org/2605103003 Cr-Commit-Position: refs/heads/master@{#42071} Committed: https://chromium.googlesource.com/v8/v8/+/f81590a1c8344cf87e72e312722abe0b35d... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/v8/v8/+/f81590a1c8344cf87e72e312722abe0b35d... |
