Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2605043002: [csa] micro-optimization of Allocation (Closed)

Created:
3 years, 11 months ago by danno
Modified:
3 years, 11 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[csa] micro-optimization of Allocation Instead of loading the address both the limit and top pointers, rely on the property that the limit pointer is always directly after the top pointer so that it can be loaded with the limit pointer's address plus a fixed offset. This generates smaller code and reduces the number of registers required by the allocation sequence by one. LOG=N R=epertoso@chromium.org Review-Url: https://codereview.chromium.org/2605043002 Cr-Commit-Position: refs/heads/master@{#41975} Committed: https://chromium.googlesource.com/v8/v8/+/133b8dfa198d9a340a160e08001e8857a63b74f9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M src/code-stub-assembler.cc View 1 chunk +11 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
danno
ptal
3 years, 11 months ago (2016-12-28 15:54:31 UTC) #3
epertoso
Neat, lgtm.
3 years, 11 months ago (2016-12-28 15:59:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2605043002/1
3 years, 11 months ago (2016-12-28 16:22:35 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2016-12-28 16:24:15 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/133b8dfa198d9a340a160e08001e8857a63...

Powered by Google App Engine
This is Rietveld 408576698