[ios] Prevents history navigation items from being voice-over selectable while not visible.

Prevents history navigation items from being voice-over selectable while not visible.

Removing accessibility traits for these navigation items or disabling them, didn't 
prevent them from being voice-over selectable while not visible due to the search bar     
being presented on top. 

Setting the view's accessibilityViewIsModal to YES fixed the problem but prevented    
the history results from being voice-over selectable.

For these reasons the current approach was used.

BUG=674891
Review-Url: https://codereview.chromium.org/2605023002
Cr-Commit-Position: refs/heads/master@{#441672}
Committed: https://chromium.googlesource.com/chromium/src/+/c0d82cf0179b873629fb2cbf2c253e9edc591920

[sczs, 2016-12-28 12:43:51]

Description was changed from

==========
Prevents history navigation items from being voice-over selectable while in
background.

BUG=674891
==========

to

==========
Prevents history navigation items from being voice-over selectable while not
visible.

Removing accessibility traits for these navigation items or disabling them,
didn't prevent them from being voice-over selectable while not visible due to
the search bar     
being presented on top. 

Setting the view's accessibilityViewIsModal to YES prevented the history results
from
being voice-over selectable.

For these reason the current approach was used.

BUG=674891
==========

[sczs, 2016-12-28 12:43:51]

sczs@chromium.org changed reviewers:
+ lpromero@chromium.org

[sczs, 2016-12-28 12:44:12]

Description was changed from

==========
Prevents history navigation items from being voice-over selectable while not
visible.

Removing accessibility traits for these navigation items or disabling them,
didn't prevent them from being voice-over selectable while not visible due to
the search bar     
being presented on top. 

Setting the view's accessibilityViewIsModal to YES prevented the history results
from
being voice-over selectable.

For these reason the current approach was used.

BUG=674891
==========

to

==========
Prevents history navigation items from being voice-over selectable while not
visible.

Removing accessibility traits for these navigation items or disabling them,
didn't 
prevent them from being voice-over selectable while not visible due to the
search bar     
being presented on top. 

Setting the view's accessibilityViewIsModal to YES prevented the history results
from
being voice-over selectable.

For these reason the current approach was used.

BUG=674891
==========

[sczs, 2016-12-28 12:49:52]

Description was changed from

==========
Prevents history navigation items from being voice-over selectable while not
visible.

Removing accessibility traits for these navigation items or disabling them,
didn't 
prevent them from being voice-over selectable while not visible due to the
search bar     
being presented on top. 

Setting the view's accessibilityViewIsModal to YES prevented the history results
from
being voice-over selectable.

For these reason the current approach was used.

BUG=674891
==========

to

==========
Prevents history navigation items from being voice-over selectable while not
visible.

Removing accessibility traits for these navigation items or disabling them,
didn't 
prevent them from being voice-over selectable while not visible due to the
search bar     
being presented on top. 

Setting the view's accessibilityViewIsModal to YES prevented the history results
from
being voice-over selectable.

For these reasons the current approach was used.

BUG=674891
==========

[sczs, 2016-12-28 12:51:05]

Description was changed from

==========
Prevents history navigation items from being voice-over selectable while not
visible.

Removing accessibility traits for these navigation items or disabling them,
didn't 
prevent them from being voice-over selectable while not visible due to the
search bar     
being presented on top. 

Setting the view's accessibilityViewIsModal to YES prevented the history results
from
being voice-over selectable.

For these reasons the current approach was used.

BUG=674891
==========

to

==========
Prevents history navigation items from being voice-over selectable while not
visible.

Removing accessibility traits for these navigation items or disabling them,
didn't 
prevent them from being voice-over selectable while not visible due to the
search bar     
being presented on top. 

Setting the view's accessibilityViewIsModal to YES fixed the problem but
prevented    
the history results from being voice-over selectable.

For these reasons the current approach was used.

BUG=674891
==========

[sczs, 2016-12-28 12:51:21]

sczs@chromium.org changed reviewers:
+ sczs@chromium.org

[lpromero, 2017-01-04 10:07:46]

Could you try instead to post a UIAccessibilityLayoutChangedNotification when
entering and leaving the search mode? Would that make the occluded elements
invisible to VoiceOver? To me that would be the correct way to implement it.

If it doesn’t work, your workaround would look ok.

[sczs, 2017-01-04 23:28:14]

On 2017/01/04 10:07:46, lpromero wrote:
> Could you try instead to post a UIAccessibilityLayoutChangedNotification when
> entering and leaving the search mode? Would that make the occluded elements
> invisible to VoiceOver? To me that would be the correct way to implement it.
> 
> If it doesn’t work, your workaround would look ok.

Hi Louis, Forgot to mention that I also tried that but didn't work. We should
take this issue into account if this screen gets reimplemented in the future.

[lpromero, 2017-01-05 10:47:43]

On 2017/01/04 23:28:14, sczs wrote:
> On 2017/01/04 10:07:46, lpromero wrote:
> > Could you try instead to post a UIAccessibilityLayoutChangedNotification
when
> > entering and leaving the search mode? Would that make the occluded elements
> > invisible to VoiceOver? To me that would be the correct way to implement it.
> > 
> > If it doesn’t work, your workaround would look ok.
> 
> Hi Louis, Forgot to mention that I also tried that but didn't work. We should
> take this issue into account if this screen gets reimplemented in the future.

Can you add a comment where you see fit then?

lgtm

[sczs, 2017-01-05 16:22:49]

The CQ bit was checked by sczs@chromium.org

[sczs, 2017-01-05 16:22:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2605023002/#ps20001
(title: "Add comment for future refactoring.")

[commit-bot: I haz the power, 2017-01-05 16:23:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sczs, 2017-01-05 16:23:10]

On 2017/01/05 10:47:43, lpromero wrote:
> On 2017/01/04 23:28:14, sczs wrote:
> > On 2017/01/04 10:07:46, lpromero wrote:
> > > Could you try instead to post a UIAccessibilityLayoutChangedNotification
> when
> > > entering and leaving the search mode? Would that make the occluded
elements
> > > invisible to VoiceOver? To me that would be the correct way to implement
it.
> > > 
> > > If it doesn’t work, your workaround would look ok.
> > 
> > Hi Louis, Forgot to mention that I also tried that but didn't work. We
should
> > take this issue into account if this screen gets reimplemented in the
future.
> 
> Can you add a comment where you see fit then?
> 
> lgtm

Sounds good, added a comment.

[commit-bot: I haz the power, 2017-01-05 16:38:30]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483633369358170,
"parent_rev": "2d09be5a8aa394eba361b86e84718c6b45c286ad", "commit_rev":
"c0d82cf0179b873629fb2cbf2c253e9edc591920"}

[commit-bot: I haz the power, 2017-01-05 16:38:58]

Description was changed from

==========
Prevents history navigation items from being voice-over selectable while not
visible.

Removing accessibility traits for these navigation items or disabling them,
didn't 
prevent them from being voice-over selectable while not visible due to the
search bar     
being presented on top. 

Setting the view's accessibilityViewIsModal to YES fixed the problem but
prevented    
the history results from being voice-over selectable.

For these reasons the current approach was used.

BUG=674891
==========

to

==========
Prevents history navigation items from being voice-over selectable while not
visible.

Removing accessibility traits for these navigation items or disabling them,
didn't 
prevent them from being voice-over selectable while not visible due to the
search bar     
being presented on top. 

Setting the view's accessibilityViewIsModal to YES fixed the problem but
prevented    
the history results from being voice-over selectable.

For these reasons the current approach was used.

BUG=674891

Review-Url: https://codereview.chromium.org/2605023002
Cr-Commit-Position: refs/heads/master@{#441672}
Committed:
https://chromium.googlesource.com/chromium/src/+/c0d82cf0179b873629fb2cbf2c25...
==========

[commit-bot: I haz the power, 2017-01-05 16:38:59]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c0d82cf0179b873629fb2cbf2c25...