Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1398)

Issue 2604993002: Record search geolocation pre-disclosure metrics earlier (Closed)

Created:
3 years, 11 months ago by benwells
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Record search geolocation pre-disclosure metrics earlier The metrics are meant to record the distribution of geolocation permissions for the DSE CCTLD origin, but are recorded after the permissions are checked. This means all metrics recorded are ASK. BUG=675503 Review-Url: https://codereview.chromium.org/2585153002 Cr-Commit-Position: refs/heads/master@{#439639} (cherry picked from commit 51cb46ec4e347179835637fe59ace00c707ba074) Committed: https://chromium.googlesource.com/chromium/src/+/48b4ef3b15e8431ff93954be5bc72af1d1a69429

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/android/search_geolocation_disclosure_tab_helper.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
benwells
3 years, 11 months ago (2016-12-28 03:47:17 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
48b4ef3b15e8431ff93954be5bc72af1d1a69429.

Powered by Google App Engine
This is Rietveld 408576698