Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 2585153002: Record search geolocation pre-disclosure metrics earlier (Closed)

Created:
4 years ago by benwells
Modified:
4 years ago
Reviewers:
gone
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Record search geolocation pre-disclosure metrics earlier The metrics are meant to record the distribution of geolocation permissions for the DSE CCTLD origin, but are recorded after the permissions are checked. This means all metrics recorded are ASK. BUG=675503 Committed: https://crrev.com/51cb46ec4e347179835637fe59ace00c707ba074 Cr-Commit-Position: refs/heads/master@{#439639}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/android/search_geolocation_disclosure_tab_helper.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
benwells
4 years ago (2016-12-19 04:21:49 UTC) #3
benwells
4 years ago (2016-12-19 04:21:49 UTC) #4
gone
lgtm
4 years ago (2016-12-19 19:04:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2585153002/1
4 years ago (2016-12-20 00:01:19 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 00:44:44 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-20 00:47:18 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51cb46ec4e347179835637fe59ace00c707ba074
Cr-Commit-Position: refs/heads/master@{#439639}

Powered by Google App Engine
This is Rietveld 408576698